Bug 214196 - multimedia/nordlicht: fails to build with ffmpeg 3.x
Summary: multimedia/nordlicht: fails to build with ffmpeg 3.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: needs-patch
Depends on:
Blocks: 207547
  Show dependency tree / graph
 
Reported: 2016-11-04 05:24 UTC by Jan Beich
Modified: 2016-11-04 12:08 UTC (History)
1 user (show)

See Also:
tobik: maintainer-feedback+

Attachments
nordlicht.diff (7.15 KB, patch)
2016-11-04 11:06 UTC, Tobias Kortkamp 		tobik: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2016-11-04 05:24:11 UTC 
image.c:28:24: error: use of undeclared identifier 'PIX_FMT_RGB24'; did you mean 'AV_PIX_FMT_RGB24'?
    i->frame->format = PIX_FMT_RGB24; // best choice?
                       ^~~~~~~~~~~~~
                       AV_PIX_FMT_RGB24
/usr/local/include/libavutil/pixfmt.h:64:5: note: 'AV_PIX_FMT_RGB24' declared here
    AV_PIX_FMT_RGB24,     ///< packed RGB 8:8:8, 24bpp, RGBRGB...
    ^
image.c:243:32: error: use of undeclared identifier 'PIX_FMT_RGB24'; did you mean 'AV_PIX_FMT_RGB24'?
    encoder_context->pix_fmt = PIX_FMT_RGB24;
                               ^~~~~~~~~~~~~
                               AV_PIX_FMT_RGB24
/usr/local/include/libavutil/pixfmt.h:64:5: note: 'AV_PIX_FMT_RGB24' declared here
    AV_PIX_FMT_RGB24,     ///< packed RGB 8:8:8, 24bpp, RGBRGB...
    ^

http://package23.nyi.freebsd.org/data/103i386-default-PR207547/2016-10-04_18h24m30s/logs/errors/nordlicht-0.4.4.log
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-11-04 12:04:25 UTC 
A commit references this bug:

Author: jbeich
Date: Fri Nov  4 12:03:33 UTC 2016
New revision: 425315
URL: https://svnweb.freebsd.org/changeset/ports/425315

Log:
  multimedia/nordlicht: unbreak build with ffmpeg 3.x

  image.c:28:24: error: use of undeclared identifier 'PIX_FMT_RGB24'; did you mean 'AV_PIX_FMT_RGB24'?
      i->frame->format = PIX_FMT_RGB24; // best choice?
                         ^~~~~~~~~~~~~
                         AV_PIX_FMT_RGB24
  /usr/local/include/libavutil/pixfmt.h:64:5: note: 'AV_PIX_FMT_RGB24' declared here
      AV_PIX_FMT_RGB24,     ///< packed RGB 8:8:8, 24bpp, RGBRGB...
      ^
  image.c:243:32: error: use of undeclared identifier 'PIX_FMT_RGB24'; did you mean 'AV_PIX_FMT_RGB24'?
      encoder_context->pix_fmt = PIX_FMT_RGB24;
                                 ^~~~~~~~~~~~~
                                 AV_PIX_FMT_RGB24
  /usr/local/include/libavutil/pixfmt.h:64:5: note: 'AV_PIX_FMT_RGB24' declared here
      AV_PIX_FMT_RGB24,     ///< packed RGB 8:8:8, 24bpp, RGBRGB...
      ^

  PR:		214196
  Submitted by:	Tobias Kortkamp <t@tobik.me> (maintainer)
  Obtained from:	upstream

Changes:
  head/multimedia/nordlicht/Makefile
  head/multimedia/nordlicht/files/patch-image.c
  head/multimedia/nordlicht/files/patch-source.c
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-11-04 12:06:26 UTC 
A commit references this bug:

Author: jbeich
Date: Fri Nov  4 12:06:16 UTC 2016
New revision: 425316
URL: https://svnweb.freebsd.org/changeset/ports/425316

Log:
  MFH: r425315

  multimedia/nordlicht: unbreak build with ffmpeg 3.x

  image.c:28:24: error: use of undeclared identifier 'PIX_FMT_RGB24'; did you mean 'AV_PIX_FMT_RGB24'?
      i->frame->format = PIX_FMT_RGB24; // best choice?
                         ^~~~~~~~~~~~~
                         AV_PIX_FMT_RGB24
  /usr/local/include/libavutil/pixfmt.h:64:5: note: 'AV_PIX_FMT_RGB24' declared here
      AV_PIX_FMT_RGB24,     ///< packed RGB 8:8:8, 24bpp, RGBRGB...
      ^
  image.c:243:32: error: use of undeclared identifier 'PIX_FMT_RGB24'; did you mean 'AV_PIX_FMT_RGB24'?
      encoder_context->pix_fmt = PIX_FMT_RGB24;
                                 ^~~~~~~~~~~~~
                                 AV_PIX_FMT_RGB24
  /usr/local/include/libavutil/pixfmt.h:64:5: note: 'AV_PIX_FMT_RGB24' declared here
      AV_PIX_FMT_RGB24,     ///< packed RGB 8:8:8, 24bpp, RGBRGB...
      ^

  PR:		214196
  Submitted by:	Tobias Kortkamp <t@tobik.me> (maintainer)
  Obtained from:	upstream
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2016Q4/
  branches/2016Q4/multimedia/nordlicht/Makefile
  branches/2016Q4/multimedia/nordlicht/files/patch-image.c
  branches/2016Q4/multimedia/nordlicht/files/patch-source.c
Comment 4 Jan Beich freebsd_committer freebsd_triage 2016-11-04 12:08:58 UTC 
Thanks. Landed. PORTREVISION was bumped out of caution for

  image.c:
      encoder_context->time_base.num = 1;
      encoder_context->time_base.den = 1;