Created attachment 176762 [details] upgrade Knot2 3.5.2 This patch upgrades the knot2 port to 3.5.2 which was released last Friday. Q/A has been done on 11.0, 10.3 and 9.3. This update makes PR 213952 absolete.
*** Bug 213952 has been marked as a duplicate of this bug. ***
Take.
Created attachment 176887 [details] Updated patch with correct FreeBSD_version check Hi, the corrected format for checking FreeBSD_version is in this patch. From the looks of things in https://svnweb.freebsd.org/base?view=revision&revision=307311, we can use https://svnweb.freebsd.org/base?view=revision&revision=307330 for FreeBSD_version < 1100504 for the recvmmsg.c changes. Does this make sense and does this look good to you?
Somehow my approve reply did not came trough. But yes, that looks perfect.
Hmmm, as there are multiple complaints, I think adding PORTREVISION 1 would be a good idea.
Note: you may disable it unconditionally, as the current recvmmsg implementation in FreeBSD seems very unlikely to bring any benefits to Knot.
Created attachment 177359 [details] new patch for knot2 2.3.2 - with no recvmmsg by default OK, I adapted the patch to this one. Doing Q/A on it ATM (but the machine is slow).
Comment on attachment 177359 [details] new patch for knot2 2.3.2 - with no recvmmsg by default this patch is solving the problem
A commit references this bug: Author: junovitch Date: Sun Nov 27 02:43:26 UTC 2016 New revision: 427187 URL: https://svnweb.freebsd.org/changeset/ports/427187 Log: dns/knot2: update 2.3.1 -> 2.3.2 - Disable recvmmsg by default, this impacted UDP queries on 11.0-RELEASE. It was later fixed in 11/stable in r307311 but enabling conditionally provides little benefit so just disable by default as part of update. PR: 213952, 214303 Submitted by: Leo Vandewoestijne <freebsd@dns-lab.com> (maintainer) Changes: head/dns/knot2/Makefile head/dns/knot2/distinfo
A commit references this bug: Author: junovitch Date: Sun Nov 27 02:50:03 UTC 2016 New revision: 427188 URL: https://svnweb.freebsd.org/changeset/ports/427188 Log: MFH: r424757 r427187 dns/knot2: update to 2.3.1 Changes: https://www.knot-dns.cz/2016-10-10-version-231.html PR: 213830 Submitted by: Leo Vandewoestijne (maintainer) dns/knot2: update 2.3.1 -> 2.3.2 - Disable recvmmsg by default, this impacted UDP queries on 11.0-RELEASE. It was later fixed in 11/stable in r307311 but enabling conditionally provides little benefit so just disable by default as part of update. PR: 213952, 214303 Submitted by: Leo Vandewoestijne <freebsd@dns-lab.com> (maintainer) Approved by: ports-secteam (with hat) Changes: _U branches/2016Q4/ branches/2016Q4/dns/knot-resolver/Makefile branches/2016Q4/dns/knot2/Makefile branches/2016Q4/dns/knot2/distinfo branches/2016Q4/dns/knot2/pkg-plist
Sorry for the delay on my side with other business and thank you for revised patch. Given this would be impacting 11.0-RELEASE users installing knot2 from packages and is a patch level only bump I felt it would be prudent to pull to quarterly. Thank you for your efforts!