Bug 214569 - databases/sqlite3: Update to 3.15.1
Summary: databases/sqlite3: Update to 3.15.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-16 12:38 UTC by Pavel Volkov
Modified: 2016-11-17 11:13 UTC (History)
2 users (show)

See Also:

Attachments
Update Port: databases/sqlite3 to 3.15.1 (1.57 KB, patch)
2016-11-16 12:38 UTC, Pavel Volkov 		pavelivolkov: maintainer-approval+
Details | Diff
portlint log (22.87 KB, text/plain)
2016-11-16 12:39 UTC, Pavel Volkov 		no flags Details
build log (18.82 KB, text/plain)
2016-11-16 12:40 UTC, Pavel Volkov 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Volkov 2016-11-16 12:38:29 UTC 
Created attachment 177066 [details]
Update Port: databases/sqlite3 to 3.15.1

- Updated to current version 3.15.1
- Added dependency into file sqlite3.pc (See: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=214551#c1)
Comment 1 Pavel Volkov 2016-11-16 12:39:58 UTC 
Created attachment 177067 [details]
portlint log
Comment 2 Pavel Volkov 2016-11-16 12:40:22 UTC 
Created attachment 177068 [details]
build log
Comment 3 Jan Beich freebsd_committer freebsd_triage 2016-11-16 15:09:25 UTC 
Comment on attachment 177066 [details]
Update Port: databases/sqlite3 to 3.15.1

> +pre-configure:
> +.if ${PORT_OPTIONS:MICU}
> +	@${ECHO_CMD} "Requires.private: icu-i18n" >> ${WRKSRC}/sqlite3.pc.in
> +.endif

Convert to option helpers, see /usr/ports/CHANGES from 20150701. However, to drop bsd.port.options.mk line pre-configure conditional needs to use sh(1) syntax rather than make(1).

> +.if ${PORT_OPTIONS:MEDITLINE}
> +	@${ECHO_CMD} "Requires.private: libedit" >> ${WRKSRC}/sqlite3.pc.in
> +.endif

Does anything link against bin/sqlite3 rather than lib/libsqlite3.so ? "Libs.private: -lpthread" for THREADS option (via LDFLAGS -> LIBS) would make more sense.
Comment 4 Jan Beich freebsd_committer freebsd_triage 2016-11-16 15:56:11 UTC 
_LDFLAGS -> _LIBS would work for both THREADS and ICU because sqlite3.pc.in already contains "Libs.private: @LIBS@".more correct

Note, the update is also required for firefox 52 to arrive around 2017-03-07.

> lib/libsqlite3.so

A typo: s/.so/.a/
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-11-16 18:11:01 UTC 
A commit references this bug:

Author: jbeich
Date: Wed Nov 16 18:10:35 UTC 2016
New revision: 426253
URL: https://svnweb.freebsd.org/changeset/ports/426253

Log:
  databases/sqlite3: update to 3.15.1

  - Add missing deps for `pkg-config sqlite3 --libs --static`

  Changes:	https://sqlite.org/releaselog/3_15_1.html
  ABI:		https://abi-laboratory.pro/tracker/timeline/sqlite/
  PR:		214569
  Submitted by:	Pavel Volkov <pavelivolkov@gmail.com> (maintainer)

Changes:
  head/databases/sqlite3/Makefile
  head/databases/sqlite3/distinfo
Comment 6 Jan Beich freebsd_committer freebsd_triage 2016-11-16 18:12:37 UTC 
Thanks. Landed.
Comment 7 Pavel Volkov 2016-11-17 11:13:34 UTC 
(In reply to Jan Beich (mail not working) from comment #3,4)
Brilliant! Thank you. And thanks for the "option helpers".