Bug 214812 - [patch] misc/mc: get rid of mc.png and mc.desktop when building without X11 support
Summary: [patch] misc/mc: get rid of mc.png and mc.desktop when building without X11 s...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Ben Woods
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-11-25 06:03 UTC by Robert Schulze
Modified: 2017-03-06 08:07 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (woodsb02)

Attachments
Patch Makefile and pkg-plist (1.78 KB, patch)
2016-11-25 06:03 UTC, Robert Schulze 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Schulze 2016-11-25 06:03:32 UTC 
Created attachment 177368 [details]
Patch Makefile and pkg-plist

Even without enabling X11, the port tries to download mc.png from arbitrary sources and fails. I made the icon and desktop-entry configurable.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-03-06 08:06:11 UTC 
A commit references this bug:

Author: woodsb02
Date: Mon Mar  6 08:05:55 UTC 2017
New revision: 435520
URL: https://svnweb.freebsd.org/changeset/ports/435520

Log:
  misc/mc: Only install desktop entry and icon if X11 option is enabled

  PR:		214812
  Submitted by:	Robert Schulze <rs@bytecamp.net>

Changes:
  head/misc/mc/Makefile
  head/misc/mc/distinfo
  head/misc/mc/files/mc.png
  head/misc/mc/pkg-plist
Comment 2 Ben Woods freebsd_committer freebsd_triage 2017-03-06 08:07:05 UTC 
Committed with some minor changes to include the icon in the ports tree at misc/mc/files/mc.png. Thanks for the patch :)