Bug 214826 - net/p5-Net-Server: add missing net/p5-IO-Socket-INET6 dependency
Summary: net/p5-Net-Server: add missing net/p5-IO-Socket-INET6 dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Po-Chuan Hsieh
URL:
Keywords: needs-qa
Depends on:
Blocks: 214364
  Show dependency treegraph
 
Reported: 2016-11-25 12:33 UTC by Mel Pilgrim
Modified: 2016-11-25 16:27 UTC (History)
3 users (show)

See Also:
ports.maintainer: maintainer-feedback? (perl)
koobs: merge-quarterly?


Attachments
Patch to add missing dependency (692 bytes, patch)
2016-11-25 12:33 UTC, Mel Pilgrim
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mel Pilgrim 2016-11-25 12:33:00 UTC
Created attachment 177383 [details]
Patch to add missing dependency

At least Net/Server/Proto.pm also requires IO::Socket::INET6 (line 122) when IPv6 is enabled, so the port needs net/p5-IO-Socket-INET6 in the IPV6 option dependency list.  Reference bug #214364 for an example of this occurring.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-11-25 12:37:43 UTC
@Wen Would you like to take this given it blocks bug 214364?
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2016-11-25 12:39:12 UTC
Comment on attachment 177383 [details]
Patch to add missing dependency

Approved by: portmgr (blanket)
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-11-25 16:26:02 UTC
A commit references this bug:

Author: sunpoet
Date: Fri Nov 25 16:25:42 UTC 2016
New revision: 427117
URL: https://svnweb.freebsd.org/changeset/ports/427117

Log:
  - Add missing dependency for IPV6 option
  - Bump PORTREVISION for dependency change

  PR:		214826
  Submitted by:	Melissa Pilgrim <ports.maintainer@evilphi.com>

Changes:
  head/net/p5-Net-Server/Makefile
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2016-11-25 16:27:06 UTC
Committed. Thanks!