Bug 214893 - www/py-kallithea: Fix RC script
Summary: www/py-kallithea: Fix RC script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Rene Ladan
URL:
Keywords: easy, needs-qa
Depends on:
Blocks:
 
Reported: 2016-11-28 00:20 UTC by Ilia Skalozubov
Modified: 2016-12-13 19:21 UTC (History)
3 users (show)

See Also:
freebsd: maintainer-feedback+
koobs: merge-quarterly?

Attachments
Patch to fixes rc script (816 bytes, patch)
2016-11-28 00:20 UTC, Ilia Skalozubov 		freebsd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilia Skalozubov 2016-11-28 00:20:04 UTC 
Created attachment 177467 [details]
Patch to fixes rc script

This patch fixes a problem with starting rc-script caused by unnecessary using --user and --group arguments for paster.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-11-28 13:05:59 UTC 
Thank you Ilia. Please:

- Confirm this change passes QA (portlint, poudriere)
- Set maintainer-approval to + on attachments for ports you are MAINTAINER of. Attachment -> Details -> maintainer-approval [+]
Comment 2 Ilia Skalozubov 2016-11-28 22:06:54 UTC 
portlint: OK (looks fine.)
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2016-12-11 18:55:51 UTC 
I noticed in poudriere that the port does not install any architecture-specific files, is it OK to add NO_ARCH=yes to the Makefile ?
Comment 4 Ilia Skalozubov 2016-12-12 03:46:24 UTC 
(In reply to Rene Ladan from comment #3)

Thanks for the tip, I actually forgot to add NO_ARCH=yes.
Comment 5 Rene Ladan freebsd_committer freebsd_triage 2016-12-12 20:58:29 UTC 
Committed, 2016Q4 merge request sent.
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-12-12 20:59:21 UTC 
A commit references this bug:

Author: rene
Date: Mon Dec 12 20:58:11 UTC 2016
New revision: 428440
URL: https://svnweb.freebsd.org/changeset/ports/428440

Log:
  www/py-kallithea: fix RC script

  While here, add NO_ARCH

  PR:		214893
  Submitted by:	maintainer (freebsd@skinc.ru)
  MFH:		2016Q4

Changes:
  head/www/py-kallithea/Makefile
  head/www/py-kallithea/files/kallithea.in
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-12-13 19:20:13 UTC 
A commit references this bug:

Author: rene
Date: Tue Dec 13 19:19:16 UTC 2016
New revision: 428526
URL: https://svnweb.freebsd.org/changeset/ports/428526

Log:
  MFH: r428440

  www/py-kallithea: fix RC script

  While here, add NO_ARCH

  PR:		214893
  Submitted by:	maintainer (freebsd@skinc.ru)

  Approved by:	ports-secteam (junovitch)

Changes:
_U  branches/2016Q4/
  branches/2016Q4/www/py-kallithea/Makefile
  branches/2016Q4/www/py-kallithea/files/kallithea.in
Comment 8 Rene Ladan freebsd_committer freebsd_triage 2016-12-13 19:21:08 UTC 
Merged to 2016Q4