Bug 215224 - www/py-kallithea : update sqlalchemy dependency
Summary: www/py-kallithea : update sqlalchemy dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rene Ladan
URL:
Keywords: needs-qa, patch-ready
Depends on:
Blocks:
 
Reported: 2016-12-11 16:52 UTC by Rene Ladan
Modified: 2016-12-25 10:39 UTC (History)
1 user (show)

See Also:
freebsd: maintainer-feedback+


Attachments
patch to update sqlalchemy dependency (897 bytes, patch)
2016-12-11 16:52 UTC, Rene Ladan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rene Ladan freebsd_committer freebsd_triage 2016-12-11 16:52:50 UTC
Created attachment 177880 [details]
patch to update sqlalchemy dependency

Update the sqlalchemy dependency from 0.7 to 1.0, as the former expired both in the Ports Tree and upstream.

The port builds fine, but preferably needs run-time testing.
Comment 1 Rene Ladan freebsd_committer freebsd_triage 2016-12-24 14:40:15 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-12-24 14:40:56 UTC
A commit references this bug:

Author: rene
Date: Sat Dec 24 14:39:51 UTC 2016
New revision: 429359
URL: https://svnweb.freebsd.org/changeset/ports/429359

Log:
  www/py-kallithea: update sqlalchemy dependency from 0.7 (expired) to 1.0

  PR:		215224
  Submitted by:	myself
  Approved by:	maintainer (freebsd@skinc.ru)

Changes:
  head/www/py-kallithea/Makefile
Comment 3 Ilia Skalozubov 2016-12-24 14:57:35 UTC
I apologize for the delay.
According to my research, py-kallithea does not depend on a particular version of sqlalchemy, but it has dependencies that require it.
I have tested for compatibility with sqlalchemy10 and sqlalchemy11 by one week each, and I have not noticed any problems.
Unfortunately, I have not yet found the correct solution for Makefile's dependency of sqlalchemy without specifying the version. I'm going to do it later in a separate bug report.
Comment 4 Rene Ladan freebsd_committer freebsd_triage 2016-12-25 10:39:35 UTC
No problems regarding the delay, the extra testing is definitely appreciated and it is even within the maintainer timeout window of 14 days.

Regarding a version-agnostic dependency of sqlalchemy: perhaps it is possible but I would have to read the documentation/Makefiles. One generic solution for this that is being worked on is the concept of flavors, where a port can depend on any version of sqlalchemy that is installed and acceptable (e.g. sqlalchemy>=10 would match 1.0, 1.1, 1.2 etc but not 0.9) or even depend on any webserver that is installed (apache, nginx, ...)