Bug 215369 - devel/kBuild: Re-allow building with clang [patch]
Summary: devel/kBuild: Re-allow building with clang [patch]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Virtualbox Team (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-12-18 02:17 UTC by Adam Weinberger
Modified: 2018-05-18 15:44 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (vbox)


Attachments
GCC option (1.29 KB, patch)
2016-12-18 02:17 UTC, Adam Weinberger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer freebsd_triage 2016-12-18 02:17:01 UTC
Created attachment 178042 [details]
GCC option

For very simple uses, GCC isn't required for kBuild. Under most circumstances it is, but when you only need virtualbox-ose-additions without X11 and you're on amd64/i386, GCC isn't necessary.

It would be really nice not to have to build GCC and all its dependencies.

The attached patch makes GCC optional, and enabled by default, with warnings that it should only be disabled under specific circumstances (with a pkg-help file to spell out what those circumstances are).
Comment 1 Walter Schwarzenfeld 2018-01-12 10:50:20 UTC
Maintainer feedback,please!
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2018-05-08 17:33:23 UTC
(In reply to Adam Weinberger from comment #0)
This is also very useful when building a package repository only with
kernel modules in Poudriere.  With this I'm not forced to also build GCC
when only building virtualbox-ose-kmod which builds fine with Clang.

Is there a reason this wasn't committed with maintainer timeout yet?
Comment 3 Adam Weinberger freebsd_committer freebsd_triage 2018-05-08 18:04:58 UTC
(In reply to Tobias Kortkamp from comment #2)
I've been holding out hope for 18 months now that someone from the vbox team will take 30 seconds to reply to this PR, but you're right, Tobias, that's probably not going to happen.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-05-18 15:42:39 UTC
A commit references this bug:

Author: adamw
Date: Fri May 18 15:41:56 UTC 2018
New revision: 470301
URL: https://svnweb.freebsd.org/changeset/ports/470301

Log:
  devel/kBuild: Add a GCC option

  When you're building only virtualbox-ose-additions, and without any
  X-related stuff, it is sufficient to build with clang instead of
  GCC. Add a GCC option (with a warning and pkg-help saying to leave
  it enabled) to make GCC optional.

  PR:		215369
  Approved by:	maintainer timeout (17 months)

Changes:
  head/devel/kBuild/Makefile
  head/devel/kBuild/pkg-help
Comment 5 Adam Weinberger freebsd_committer freebsd_triage 2018-05-18 15:44:07 UTC
Committed after timeout