Bug 215412 - www/npm3: depend on www/node6 by default
Summary: www/npm3: depend on www/node6 by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-19 13:00 UTC by Bradley T. Hughes
Modified: 2016-12-26 19:31 UTC (History)
2 users (show)

See Also:
bhughes: maintainer-feedback? (sunpoet)

Attachments
npm3-depend-on-node6 (1.23 KB, patch)
2016-12-19 13:00 UTC, Bradley T. Hughes 		bhughes: maintainer-approval? (sunpoet)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bradley T. Hughes freebsd_committer freebsd_triage 2016-12-19 13:00:49 UTC 
Created attachment 178091 [details]
npm3-depend-on-node6

Like www/npm2 depends on www/node4, have www/npm3 depend on node6. Add a knob to continue to depend on www/node. Change to USES+=gmake as recommended by portlint.

My thinking/rationale is that each www/node* port should have a corresponding www/npm* port. This allows ports and pkg users to be able to find and install the "right" combination:

www/npm -> www/node
www/npm3 -> www/node6
www/npm2 -> www/node4
www/npm012 -> www/node012 (will be removed in a few weeks when upstream support ends)
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-12-25 21:17:06 UTC 
A commit references this bug:

Author: sunpoet
Date: Sun Dec 25 21:16:58 UTC 2016
New revision: 429463
URL: https://svnweb.freebsd.org/changeset/ports/429463

Log:
  - Add NODE and NODE6 option
  - Change default from node to node6
  - Bump PORTREVISION for dependency change

  PR:		215412
  Submitted by:	Bradley T. Hughes <bradleythughes@fastmail.fm>

Changes:
  head/www/npm3/Makefile
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2016-12-25 21:20:45 UTC 
gmake was added as runtime dependency for bug #204547. Changes except USES=gmake are committed. Thanks!
Comment 3 Bradley T. Hughes freebsd_committer freebsd_triage 2016-12-26 19:31:31 UTC 
Right, because USES+=gmake only adds the build dependency. Thanks for the commit and feedback! :)