Bug 215532 - games/minetest: Fix movement when built with clang 3.8+
Summary: games/minetest: Fix movement when built with clang 3.8+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-24 02:59 UTC by Sean Farley
Modified: 2016-12-25 04:25 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (amdmi3)

Attachments
Patch to remove -ffast-math flag from build (780 bytes, patch)
2016-12-24 02:59 UTC, Sean Farley 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Farley freebsd_committer freebsd_triage 2016-12-24 02:59:06 UTC 
Created attachment 178242 [details]
Patch to remove -ffast-math flag from build

After a short period of time (seconds to less than a minute), movement within the game using the keyboard no longer works.  The issue is fixed by removing the -ffast-math flag.  While the issue does not appear with GCC, it does with Clang.

Upstream has removed the flag from the release builds starting with v0.4.16 (in development).  The issue is detailed here:  https://github.com/minetest/minetest/issues/4274

The recently release v0.4.15 still has the issue, so when the port is updated to that version, this fix still needs to be present.
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2016-12-24 15:08:51 UTC 
Thanks, I was just about to update the port. Will apply the fix. The same problem seem to plague freeminer, might fix it as well.
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-12-24 16:37:35 UTC 
A commit references this bug:

Author: amdmi3
Date: Sat Dec 24 16:37:22 UTC 2016
New revision: 429371
URL: https://svnweb.freebsd.org/changeset/ports/429371

Log:
  - Update to 0.4.15
  - Remove -ffast-math to fix problems when built with clang 3.8+ ([1])

  PR:		215532 [1]
  Submitted by:	scf [1]

Changes:
  head/games/minetest/Makefile
  head/games/minetest/distinfo
  head/games/minetest/files/patch-src_CMakeLists.txt
  head/games/minetest/pkg-plist
Comment 3 Sean Farley freebsd_committer freebsd_triage 2016-12-25 04:25:33 UTC 
(In reply to Dmitry Marakasov from comment #1)

It works great.  Thank you!