Created attachment 178340 [details] patch - Add LICENSE_FILE - Add misc/compat6x to LIB_DEPENDS - Fix strip shared object - Bump PORTREVISION
This seems really painful that we need libc from FreeBSD 6 for this port. What needs that functionality?
Fix assignee.
(In reply to Jason Unovitch from comment #1) This is why we need misc/compat6x ====> Compressing man pages (compress-man) ====> Running Q/A tests (stage-qa) Error: /usr/local/lib/python2.7/site-packages/selenium/webdriver/firefox/amd64/x_ignore_nofocus.so is linked to /usr/local/lib/compat/libc.so.6 from misc/compat6x but it is not declared as a dependency Error: /usr/local/lib/python2.7/site-packages/selenium/webdriver/firefox/x86/x_ignore_nofocus.so is linked to /usr/local/lib32/compat/libc.so.6 from misc/compat6x but it is not declared as a dependency ===> Installing for py27-selenium-3.0.2_1 ===> Checking if py27-selenium already installed ===> Registering installation for py27-selenium-3.0.2_1 Installing py27-selenium-3.0.2_1... ===> Cleaning for py27-selenium-3.0.2_1
Other port that currently claims libc.so.6 as a library dependency is lang/go pkg-static: (go-1.7.4,1) /usr/ports/lang/go/work/stage//usr/local/go/src/pkg/debug/elf/testdata/gcc-386-freebsd-exec - shared library libc.so.6 not found
Looks like a false positive. That .so mentions a bunch of Linux GLIBC symbol versions in the strings output and ldd recognizes it as such. % ldd ./py/selenium/webdriver/firefox/amd64/x_ignore_nofocus.so ldd: ./py/selenium/webdriver/firefox/amd64/x_ignore_nofocus.so: not a FreeBSD ELF shared object Perhaps it should be removed?
(In reply to Jason Unovitch from comment #5) Ok, I'll take a look :-)
# ldd /usr/local/lib/python2.7/site-packages/selenium/webdriver/firefox/x86/x_ignore_nofocus.so /usr/local/lib/python2.7/site-packages/selenium/webdriver/firefox/x86/x_ignore_nofocus.so: libc.so.6 => /usr/local/lib32/compat/libc.so.6 (0x28205000) # ldd /usr/local/lib/python2.7/site-packages/selenium/webdriver/firefox/amd64/x_ignore_nofocus.so /usr/local/lib/python2.7/site-packages/selenium/webdriver/firefox/amd64/x_ignore_nofocus.so: libc.so.6 => /usr/local/lib/compat/libc.so.6 (0x801609000) # file /usr/local/lib/python2.7/site-packages/selenium/webdriver/firefox/x86/x_ignore_nofocus.so /usr/local/lib/python2.7/site-packages/selenium/webdriver/firefox/x86/x_ignore_nofocus.so: ELF 32-bit LSB shared object, Intel 80386, version 1 (FreeBSD), dynamically linked, BuildID[sha1]=e61dfc1eda85dd44faca4fdd7715f302a9077b63, stripped # file /usr/local/lib/python2.7/site-packages/selenium/webdriver/firefox/amd64/x_ignore_nofocus.so /usr/local/lib/python2.7/site-packages/selenium/webdriver/firefox/amd64/x_ignore_nofocus.so: ELF 64-bit LSB shared object, x86-64, version 1 (FreeBSD), dynamically linked, BuildID[sha1]=fe29b41d8b02597921bdb6a3985241060a652aa1, stripped
(In reply to Carlos J. Puga Medina from comment #7) Yes, it's going to sound weird but now it looks good?
Before build: ./work/selenium-2.53.1/py/selenium/webdriver/firefox/amd64/x_ignore_nofocus.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=fe29b41d8b02597921bdb6a3985241060a652aa1, not stripped ./work/selenium-2.53.1/py/selenium/webdriver/firefox/x86/x_ignore_nofocus.so: ELF 32-bit LSB shared object, Intel 80386, version 1 (SYSV), dynamically linked, BuildID[sha1]=e61dfc1eda85dd44faca4fdd7715f302a9077b63, not stripped nm shows references to GLIBC. These libs don't seem to have anything to do with FreeBSD compatXX ports. Probably should not be installed or should be rebuild.
Created attachment 178367 [details] patch Summary: - Add LICENSE_FILE - Remove binary Firefox extension - Bump PORTREVISION
LGTM
A commit references this bug: Author: cpm Date: Sun Jan 1 13:01:53 UTC 2017 New revision: 430251 URL: https://svnweb.freebsd.org/changeset/ports/430251 Log: www/py-selenium: minor fixes - Add LICENSE_FILE - Remove binary Firefox extensions - Bump PORTREVISION PR: 215624 Submitted by: cpm Reviewed by: amdmi3, junovitch (mentors) Approved by: douglas@douglasthrift.net (maintainer), amdmi3 (mentor) Changes: head/www/py-selenium/Makefile head/www/py-selenium/files/ head/www/py-selenium/files/patch-setup.py
Committed, thanks!