Bug 215766 - devel/pear-PHPUnit3 is EOL since 2014
Summary: devel/pear-PHPUnit3 is EOL since 2014
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Torsten Zuehlsdorff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-04 15:18 UTC by Jochen Neumeister
Modified: 2017-01-06 17:16 UTC (History)
3 users (show)

See Also:

Attachments
Patch (879 bytes, patch)
2017-01-04 15:18 UTC, Jochen Neumeister 		joneum: maintainer-approval+
Details | Diff
Patch (395 bytes, patch)
2017-01-04 17:23 UTC, Jochen Neumeister 		joneum: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jochen Neumeister freebsd_committer freebsd_triage 2017-01-04 15:18:50 UTC 
Created attachment 178509 [details]
Patch

https://github.com/sebastianbergmann/phpunit/wiki/End-of-Life-for-PEAR-Installation-Method

phpunit3 is EOL since 2014.
Comment 1 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-01-04 17:10:05 UTC 
The EXPIRATION_DATE is meant to be in the future. This way you allow user of the port to notice its future removal and give them a chance to check for an alternative.

Since there is devel/phpunit its wise to point user to them.

Also do not remove it from devel/Makefile. A committer will do this, after the future EXPIRATION_DATE has passed.
Comment 2 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-01-04 17:17:49 UTC 
Just some short additional information:
https://www.freebsd.org/doc/en/books/porters-handbook/dads-deprecated.html
Comment 3 Jochen Neumeister freebsd_committer freebsd_triage 2017-01-04 17:23:44 UTC 
Created attachment 178516 [details]
Patch

Thanks for your hint, Torsten.

This is the first with EOL for me.

I set the EOL date in EXPIRATION_DATE: 21.01.2017.

I see, devel/phpunit is version 5. Version 4 (4.8) is not into the Ports.

Would not it be better for the future, this Ports rename with the Version? (phpunit4, phpunit5). 

phpunit will release phpunit6 this year, and i think, its a good idea to make a new Port with PHPUnit 4.8, too.

For this Port: Is it helpful to set an Info into pkg-descr with the EOL of this port and an alternative?
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-01-05 10:48:24 UTC 
A commit references this bug:

Author: tz
Date: Thu Jan  5 10:47:27 UTC 2017
New revision: 430626
URL: https://svnweb.freebsd.org/changeset/ports/430626

Log:
  devel/pear-PHPUnit3: Mark DEPRECATED and set EXPIRATION_DATE to 2016-01-31

  PR:           215766
  Submitted by: Jochen Neumeister (maintainer)

Changes:
  head/devel/pear-PHPUnit3/Makefile
Comment 5 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-01-05 10:51:37 UTC 
Committed, thanks!

I took the freedom to rephrase the warning for a better guidance of the user. And i lifted the EXPIRATION_DATE to the end of the month.

I'm currently unsure how to handle PHPUnit 6. Till now the update of the ports where just fine. But the next version will only run with PHP 7.0+ which isn't the default version of our portstree. So it could be a good idea to create a new port for it.

On the other hand PHPUnit 5.7 is no longer supported when version 6 is released.
Comment 6 Jochen Neumeister freebsd_committer freebsd_triage 2017-01-06 17:16:00 UTC 
devel/pear-PHPUnit_MockObject and devel/pear-channel-phpunit needs pear-PHPUnit3. I'm sure to put this also EOL.

Can not they also use devel/phpunit?