Comment 1 Bradley T. Hughes 2017-01-05 11:11:33 UTC

testport: OK (poudriere, 11.0-R, 10.3-R, amd64/i386, default options)
testport: OK (poudriere, 11.0-R, 10.3-R, amd64/i386, BUNDLED_SSL)

Comment 2 Po-Chuan Hsieh 2017-01-05 12:35:58 UTC

It seems upstream rerolled the tarball. I got:

SHA256 (node-v4.7.1.tar.gz) = 9c0472b8faf03758b6ff86e4a05d03e399b94b6b83c6c0847e5eaedb448a1c49
SIZE (node-v4.7.1.tar.gz) = 22731075

Please confirm if they have identical files. Thanks!

Comment 3 Bradley T. Hughes 2017-01-05 13:14:02 UTC

Good catch :) I just checked, and the extracted archives appear to be identical. I can update the patch with the new hash and size.

Comment 4 Bradley T. Hughes 2017-01-05 13:29:44 UTC

Created attachment 178545 [details]
v4.7.1 with updated archive hash/size

Comment 5 Po-Chuan Hsieh 2017-01-05 18:37:32 UTC

===>  Building for node4-4.7.1
gmake[1]: Entering directory '/wrkdirs/usr/ports/www/node4/work/node-v4.7.1'
gmake[1]: Warning: File 'Makefile' has modification time 17439 s in the future
/usr/local/bin/python2.7 tools/gyp_node.py -f make
gmake -C out BUILDTYPE=Release V=1
gmake[2]: Entering directory '/wrkdirs/usr/ports/www/node4/work/node-v4.7.1/out'
gmake[2]: Warning: File '../deps/cares/cares.gyp' has modification time 17438 s in the future
  cd ..; ./tools/gyp_node.py -fmake --ignore-environment "--toplevel-dir=." -I/wrkdirs/usr/ports/www/node4/work/node-v4.7.1/common.gypi -I/wrkdirs/usr/ports/www/node4/work/node-v4.7.1/config.gypi "--depth=." "-Goutput_dir=/wrkdirs/usr/ports/www/node4/work/node-v4.7.1/out" "--generator-output=/wrkdirs/usr/ports/www/node4/work/node-v4.7.1/out" "-Dcomponent=static_library" "-Dlibrary=static_library" "-Dlinux_use_bundled_binutils=0" "-Dlinux_use_bundled_gold=0" "-Dlinux_use_gold_flags=0" node.gyp
env: python: No such file or directory
gmake[2]: *** [Makefile:510: Makefile] Error 127
gmake[2]: Leaving directory '/wrkdirs/usr/ports/www/node4/work/node-v4.7.1/out'
gmake[1]: *** [Makefile:64: node] Error 2
gmake[1]: Leaving directory '/wrkdirs/usr/ports/www/node4/work/node-v4.7.1'
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make: stopped in /usr/ports/www/node4

Comment 6 Bradley T. Hughes 2017-01-05 18:42:08 UTC

I cannot reproduce that build failure. What is your system clock set to? I noticed the following from gmake:

gmake[1]: Warning: File 'Makefile' has modification time 17439 s in the future

Comment 7 Bradley T. Hughes 2017-01-05 19:03:06 UTC

(In reply to Po-Chuan Hsieh from comment #5)

FYI, I just re-ran 'poudriere testport' on all 4 of my jails: 11.0-RELEASE, 10.3-RELEASE, each on amd64 and i386. I ran the build twice, once with the default options, and once with BUNDLED_SSL enabled. All 8 builds succeeded.

Does your build still fail?

Comment 8 Po-Chuan Hsieh 2017-01-05 19:10:40 UTC

(In reply to Bradley T. Hughes from comment #6)

You're right. I forgot to sync time after restoring the VM. It builds OK now.

Comment 9 Bradley T. Hughes 2017-01-05 19:38:47 UTC

(In reply to Po-Chuan Hsieh from comment #8)

Great! :)

Comment 10 Bradley T. Hughes 2017-01-05 20:16:27 UTC

Created attachment 178557 [details]
www/node4 with updated pkg-message

New patch with updated pkg-message.

Comment 11 Bradley T. Hughes 2017-01-06 08:44:53 UTC

Created attachment 178570 [details]
v4.7.2

As you noticed, the v4.7.1 tarballs were inadvertently replaced, so upstream has rolled a new v4.7.2 release with no changes from v4.7.1. Latest patch uses this new version and includes an updated pkg-message after comments on PR 215776. Thanks again for your help :)

Comment 12 commit-hook 2017-01-06 20:04:01 UTC

A commit references this bug:

Author: sunpoet
Date: Fri Jan  6 20:02:55 UTC 2017
New revision: 430745
URL: https://svnweb.freebsd.org/changeset/ports/430745

Log:
  Update to 4.7.2

  - Update pkg-message

  Changes:	https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V4.md
  		https://nodejs.org/en/blog/release/v4.7.2/
  PR:		215777
  Submitted by:	Bradley T. Hughes <bradleythughes@fastmail.fm> (maintainer)

Changes:
  head/www/node4/Makefile
  head/www/node4/distinfo
  head/www/node4/pkg-message

Comment 13 Po-Chuan Hsieh 2017-01-06 20:14:01 UTC

Committed. Thanks!

Comment 14 Bradley T. Hughes 2017-01-09 20:54:43 UTC

Thanks! :)