215842 – math/pdal: update to 1.4.0

Bug 215842 - math/pdal: update to 1.4.0

Summary: math/pdal: update to 1.4.0

Status:	Closed FIXED

Alias:	None

Product:	Ports & Packages
Classification:	Unclassified
Component:	Individual Port(s) (show other bugs)
Version:	Latest
Hardware:	Any Any

Importance:	--- Affects Only Me
Assignee:	Thomas Zander

URL:
Keywords:	patch-ready

Depends on:
Blocks:

Reported:	2017-01-06 21:43 UTC by Loïc Bartoletti
Modified:	2017-02-27 17:26 UTC (History)
CC List:	2 users (show)

See Also:

Flags:	riggs: merge-quarterly+

Attachments
Update pdal to 1.4.0 (23.35 KB, patch) 2017-01-06 21:43 UTC, Loïc Bartoletti	lbartoletti: maintainer-approval+	Details \| Diff
new patch for vendor_gtest (1.03 KB, patch) 2017-01-09 22:06 UTC, Loïc Bartoletti	lbartoletti: maintainer-approval+	Details \| Diff
update pdal (25.47 KB, patch) 2017-02-13 05:29 UTC, Loïc Bartoletti	lbartoletti: maintainer-approval+	Details \| Diff
Updated patch addressing the bash completion (25.67 KB, patch) 2017-02-13 09:34 UTC, Thomas Zander	riggs: maintainer-approval? (lbartoletti)	Details \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Loïc Bartoletti freebsd_committer

2017-01-06 21:43:14 UTC

Created attachment 178588 [details]
Update pdal to 1.4.0

Update math/pdal to 1.4.0. I have also change my mail.

Poudriere 10, 11 i386/amd64
portlint ok

Merge quarterly because pdal 1.1.0 doesn't build. (Seem a problem with new gtiff version)

Changelog is important, see https://github.com/PDAL/PDAL

Comment 1 Bugzilla Automation freebsd_committer

2017-01-06 21:43:14 UTC

Maintainer informed via mail

Comment 2 Thomas Zander freebsd_committer

2017-01-07 14:58:04 UTC

Does not build in poudriere, 11/amd64:

--- test/unit/CMakeFiles/pdal_point_view_test.dir/all ---
--- test/unit/CMakeFiles/pdal_point_view_test.dir/PointViewTest.cpp.o ---
/wrkdirs/usr/ports/math/pdal/work/PDAL-1.4.0/test/unit/PointViewTest.cpp:467:5: error: use of undeclared identifier 'EXPECT_DEATH'
    EXPECT_DEATH(point_view->getFieldAs<uint8_t>(Dimension::Id::X, 1), "< m_size");
    ^
1 error generated.
*** [test/unit/CMakeFiles/pdal_point_view_test.dir/PointViewTest.cpp.o] Error code 1

make[3]: stopped in /wrkdirs/usr/ports/math/pdal/work/.build
1 error


Also your patch file seems to have an issue:
...
Skipped missing target: 'files/patch-vendor_gtest_include_gtest_internal_gtest-port.h'
...

Could you look into this and send a patchfile versus an up to date diff of the ports tree? Thanks!

Comment 3 Loïc Bartoletti freebsd_committer

2017-01-09 22:06:14 UTC

Created attachment 178682 [details]
new patch for vendor_gtest

Comment 4 Loïc Bartoletti freebsd_committer

2017-01-09 22:07:04 UTC

Oh, sorry. I certainly made a mistake on svn diff... Now you have the guilty patch.

Regards.

Comment 5 Thomas Zander freebsd_committer

2017-01-14 16:00:25 UTC

(In reply to lbartoletti from comment #3)

This file is identical to files/patch-vendor_gtest-1.7.0_include_gtest_internal_gtest-port.h currently in the tree (except for the time stamps) and does not help fix the build problem.

I suggest you provide one single patch file against an up to date ports tree when the issue is resolved, i.e.
- Remove attachment 178682 [details]
- Update attachment 178588 [details]

Thanks in advance

Comment 6 Thomas Zander freebsd_committer

2017-01-29 13:24:49 UTC

Any news?

Comment 7 Loïc Bartoletti freebsd_committer

2017-02-13 05:29:35 UTC

Created attachment 179925 [details]
update pdal

I hope it's ok with this new patch.

Comment 8 Thomas Zander freebsd_committer

2017-02-13 09:34:07 UTC

Created attachment 179939 [details]
Updated patch addressing the bash completion

The patch provided in attachment 179925 [details] builds fine here on 10.3 and 11, thanks for the new revision.
I have noticed that for some reason the bash completion file is not installed properly. Attached patch provides a workaround via the post-install target. Let me know if you want me to commit this. Alternative solution would be to fix the CMakeFiles, but I haven't looked into this yet. Feel free to provide a better solution.

Comment 9 Thomas Zander freebsd_committer

2017-02-19 08:22:52 UTC

Ping

Comment 10 commit-hook freebsd_committer

2017-02-27 17:24:06 UTC

A commit references this bug:

Author: riggs
Date: Mon Feb 27 17:23:58 UTC 2017
New revision: 434977
URL: https://svnweb.freebsd.org/changeset/ports/434977

Log:
  Update to upstream version 1.4.0; un-breank build; changed OPTIONs

  Details:
  - Update to upstream version 1.4.0
  - Fix build
  - Update maintainer e-mail address
  - Removed OPTIONs: GEOTIFF LIBXML2 LASZIP APPS ATTRIBUTE
  - New OPTIONs: PGPOINTCLOUD SQLITE PYTHON TESTS

  PR:		215842
  Submitted by:	lbartoletti@tuxfamily.org
  Reviewed by:	riggs
  Approved by:	maintainer timeout
  MFH:		2017Q1 (build fix blanket)

Changes:
  head/math/pdal/Makefile
  head/math/pdal/distinfo
  head/math/pdal/files/patch-apps_CMakeLists.txt
  head/math/pdal/files/patch-dimbuilder_CMakeLists.txt
  head/math/pdal/files/patch-git_080e614
  head/math/pdal/files/patch-git_3c7e997
  head/math/pdal/files/patch-git_5a0b123
  head/math/pdal/files/patch-git_c8a1f88
  head/math/pdal/files/patch-pdal_util_CMakeLists.txt
  head/math/pdal/files/patch-src_PluginManager.cpp
  head/math/pdal/files/patch-vendor_gtest-1.7.0_include_gtest_internal_gtest-port.h
  head/math/pdal/files/patch-vendor_gtest_include_gtest_internal_gtest-port.h
  head/math/pdal/pkg-plist

Comment 11 commit-hook freebsd_committer

2017-02-27 17:26:09 UTC

A commit references this bug:

Author: riggs
Date: Mon Feb 27 17:25:33 UTC 2017
New revision: 434978
URL: https://svnweb.freebsd.org/changeset/ports/434978

Log:
  MFH: r434977

  Update to upstream version 1.4.0; un-breank build; changed OPTIONs

  Details:
  - Update to upstream version 1.4.0
  - Fix build
  - Update maintainer e-mail address
  - Removed OPTIONs: GEOTIFF LIBXML2 LASZIP APPS ATTRIBUTE
  - New OPTIONs: PGPOINTCLOUD SQLITE PYTHON TESTS

  PR:		215842
  Submitted by:	lbartoletti@tuxfamily.org
  Reviewed by:	riggs
  Approved by:	maintainer timeout

  Approved by:	ports-secteam (build fix blanket)

Changes:
_U  branches/2017Q1/
  branches/2017Q1/math/pdal/Makefile
  branches/2017Q1/math/pdal/distinfo
  branches/2017Q1/math/pdal/files/patch-apps_CMakeLists.txt
  branches/2017Q1/math/pdal/files/patch-dimbuilder_CMakeLists.txt
  branches/2017Q1/math/pdal/files/patch-git_080e614
  branches/2017Q1/math/pdal/files/patch-git_3c7e997
  branches/2017Q1/math/pdal/files/patch-git_5a0b123
  branches/2017Q1/math/pdal/files/patch-git_c8a1f88
  branches/2017Q1/math/pdal/files/patch-pdal_util_CMakeLists.txt
  branches/2017Q1/math/pdal/files/patch-src_PluginManager.cpp
  branches/2017Q1/math/pdal/files/patch-vendor_gtest-1.7.0_include_gtest_internal_gtest-port.h
  branches/2017Q1/math/pdal/files/patch-vendor_gtest_include_gtest_internal_gtest-port.h
  branches/2017Q1/math/pdal/pkg-plist