Bug 216045 - security/gnutls: no longer builds on aarch64 after 3.5.8 update (3265 ports skipped)
Summary: security/gnutls: no longer builds on aarch64 after 3.5.8 update (3265 ports s...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords: regression
Depends on:
Blocks: 201763
  Show dependency tree / graph
 
Reported: 2017-01-14 01:27 UTC by Jan Beich
Modified: 2018-01-05 03:01 UTC (History)
0 users

See Also:
tijl: maintainer-feedback+

Attachments
v0 (1.20 KB, patch)
2017-01-14 01:46 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2017-01-14 01:27:22 UTC 
lib/accelerated/aarch64/elf/aes-aarch64.s.tmp.S:5:1: error: unknown directive
.arch armv8-a+crypto
^
lib/accelerated/aarch64/elf/aes-aarch64.s.tmp.S:49:2: error: instruction requires: crypto
 aese v6.16b,v0.16b
 ^

http://thunderx1.nyi.freebsd.org/data/110arm64-default/431215/logs/errors/gnutls-3.5.8.log
http://thunderx1.nyi.freebsd.org/data/110arm64-default/430080/logs/gnutls-3.4.17.log
Comment 1 Jan Beich freebsd_committer freebsd_triage 2017-01-14 01:33:07 UTC 
Not an issue for 11.1 (or /head) but 10.0 may need CFLAGS+=-no-integrated-as. /usr/bin/as doesn't exist, so we don't need to pass -B or COMPILER_PATH can just use BUILD_DEPENDS+=as:devel/binutils with appropriate OSVERSION checks.

$ cat >a.s
.arch armv8-a+crypto
aese v6.16b,v0.16b

$ clang39 -target aarch64-pc-freebsd11.0 -c a.s

$ clang38 -target aarch64-pc-freebsd11.0 -c a.s
a.s:1:1: error: unknown directive
.arch armv8-a+crypto
^
a.s:2:1: error: instruction requires: crypto
aese v6.16b,v0.16b
^
Comment 2 Jan Beich freebsd_committer freebsd_triage 2017-01-14 01:46:07 UTC 
Created attachment 178869 [details]
v0

Haven't tested yet.
Comment 3 Tijl Coosemans freebsd_committer freebsd_triage 2017-01-14 16:05:49 UTC 
If it works feel free to commit this.  I cannot test it.
Comment 4 Jan Beich freebsd_committer freebsd_triage 2017-01-14 19:53:35 UTC 
Comment on attachment 178869 [details]
v0

110aarch64 builds fine but head-aarch64 still fails. It really wants Clang 4.0.

elf/aes-aarch64.s:39:1: error: unexpected token at start of statement
#
^
lib/accelerated/aarch64/elf/aes-aarch64.s.tmp.S:35:2: error: instruction requires: neon
 eor v0.16b,v0.16b,v0.16b
 ^
lib/accelerated/aarch64/elf/aes-aarch64.s.tmp.S:36:2: error: instruction requires: neon
 ld1 {v3.16b},[x0],#16
 ^
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-01-14 20:51:58 UTC 
A commit references this bug:

Author: jbeich
Date: Sat Jan 14 20:51:33 UTC 2017
New revision: 431494
URL: https://svnweb.freebsd.org/changeset/ports/431494

Log:
  security/gnutls: unbreak aarch64 after r431214

  lib/accelerated/aarch64/elf/aes-aarch64.s.tmp.S:5:1: error: unknown directive
  .arch armv8-a+crypto
  ^
  lib/accelerated/aarch64/elf/aes-aarch64.s.tmp.S:49:2: error: instruction requires: crypto
   aese v6.16b,v0.16b
   ^

  PR:		216045
  Approved by:	tijl (maintainer)

Changes:
  head/security/gnutls/Makefile
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-01-14 20:54:01 UTC 
A commit references this bug:

Author: jbeich
Date: Sat Jan 14 20:53:21 UTC 2017
New revision: 431495
URL: https://svnweb.freebsd.org/changeset/ports/431495

Log:
  MFH: r431494

  security/gnutls: unbreak aarch64 after r431214

  lib/accelerated/aarch64/elf/aes-aarch64.s.tmp.S:5:1: error: unknown directive
  .arch armv8-a+crypto
  ^
  lib/accelerated/aarch64/elf/aes-aarch64.s.tmp.S:49:2: error: instruction requires: crypto
   aese v6.16b,v0.16b
   ^

  PR:		216045
  Approved by:	tijl (maintainer)
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2017Q1/
  branches/2017Q1/security/gnutls/Makefile
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-01-05 02:58:37 UTC 
A commit references this bug:

Author: jbeich
Date: Fri Jan  5 02:58:10 UTC 2018
New revision: 458103
URL: https://svnweb.freebsd.org/changeset/ports/458103

Log:
  security/gnutls: revert r431494 per FreeBSD 11.0 EOL

  PR:		216045
  Approved by:	portmgr blanket

Changes:
  head/security/gnutls/Makefile
Comment 8 commit-hook freebsd_committer freebsd_triage 2018-01-05 03:01:41 UTC 
A commit references this bug:

Author: jbeich
Date: Fri Jan  5 03:00:39 UTC 2018
New revision: 458106
URL: https://svnweb.freebsd.org/changeset/ports/458106

Log:
  MFH: r458103

  security/gnutls: revert r431494 per FreeBSD 11.0 EOL

  PR:		216045
  Approved by:	portmgr blanket
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2018Q1/
  branches/2018Q1/security/gnutls/Makefile