Bug 216076 - editors/madedit: fails to build with clang 4.0
Summary: editors/madedit: fails to build with clang 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency tree / graph
 
Reported: 2017-01-14 16:04 UTC by Jan Beich
Modified: 2017-02-01 05:28 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2017-01-14 16:04:40 UTC 
src/MadOptionsDialog.cpp:1179:56: error: ordered comparison between pointer and zero ('const wxChar *' (aka 'const wchar_t *') and 'int')
        if(g_SelectedCommandItem->cmddata->menuid_name > 0)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
src/MadOptionsDialog.cpp:1277:42: error: ordered comparison between pointer and zero ('const wxChar *' (aka 'const wchar_t *') and 'int')
            if(tid->cmddata->menuid_name > 0)
               ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~

build log: http://sprunge.us/OiMQ
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-02-01 05:26:07 UTC 
A commit references this bug:

Author: jbeich
Date: Wed Feb  1 05:25:42 UTC 2017
New revision: 432971
URL: https://svnweb.freebsd.org/changeset/ports/432971

Log:
  editors/madedit: unbreak with clang 4.0

  src/MadOptionsDialog.cpp:1179:56: error: ordered comparison between pointer and zero
        ('const wxChar *' (aka 'const wchar_t *') and 'int')
          if(g_SelectedCommandItem->cmddata->menuid_name > 0)
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  src/MadOptionsDialog.cpp:1277:42: error: ordered comparison between pointer and zero
        ('const wxChar *' (aka 'const wchar_t *') and 'int')
              if(tid->cmddata->menuid_name > 0)
                 ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~

  PR:		216076
  Reported by:	antoine (via exp-run)

Changes:
  head/editors/madedit/files/patch-src_MadOptionsDialog.cpp