Bug 216183 - [New Port] adding games/mari0 a combine of Super Mario and Portal games
Summary: [New Port] adding games/mari0 a combine of Super Mario and Portal games
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nikolai Lifanov
URL: https://reviews.freebsd.org/D9214
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2017-01-17 15:41 UTC by Mahdi Mokhtari
Modified: 2017-01-19 16:11 UTC (History)
1 user (show)

See Also:

Attachments
Patch adds port to the tree (2.22 KB, patch)
2017-01-17 15:43 UTC, Mahdi Mokhtari 		no flags Details | Diff
Updated patch regarding to the review (2.21 KB, patch)
2017-01-18 12:06 UTC, Mahdi Mokhtari 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mahdi Mokhtari freebsd_committer freebsd_triage 2017-01-17 15:41:44 UTC 
`mari0` is a combination of familiar `Super Mario Bros. game of Nintendo` and `Portal of Valve`.
Comment 1 Nikolai Lifanov freebsd_committer freebsd_triage 2017-01-17 15:43:19 UTC 
Please attach a patch to the PR as well.
Comment 2 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-01-17 15:43:44 UTC 
Created attachment 178994 [details]
Patch adds port to the tree

Poudriere builds fine.
Portlint is fine.
Comment 3 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-01-17 15:45:42 UTC 
(In reply to Nikolai Lifanov from comment #1)
Done ;-)
Comment 4 Nikolai Lifanov freebsd_committer freebsd_triage 2017-01-17 16:02:41 UTC 
Bugzilla is the system of record for new issues, contributions, etc.
This is where interaction and work is recorded for later reference.

Differential is there to facilitate review and changes.
Comment 5 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-01-18 11:54:34 UTC 
(In reply to Nikolai Lifanov from comment #4)
I see :)
not attaching patch was a race condition, I first created review with arc, and that's why I delayed attaching patch :)

Thanks for the point BTW.
Comment 6 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-01-18 12:06:43 UTC 
Created attachment 179031 [details]
Updated patch regarding to the review
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-01-19 15:51:15 UTC 
A commit references this bug:

Author: lifanov
Date: Thu Jan 19 15:50:49 UTC 2017
New revision: 431884
URL: https://svnweb.freebsd.org/changeset/ports/431884

Log:
  new port: games/mari0

  combination of Super Mario Bros. and Portal

  PR:		216183
  Submitted by:	Mahdi Mokhtari <mokhi64@gmail.com>
  Reviewed by:	matthew
  Approved by:	matthew (mentor)
  Differential Revision:	https://reviews.freebsd.org/D9214

Changes:
  head/games/Makefile
  head/games/mari0/
  head/games/mari0/Makefile
  head/games/mari0/distinfo
  head/games/mari0/files/
  head/games/mari0/files/mari0.in
  head/games/mari0/pkg-descr
Comment 8 Nikolai Lifanov freebsd_committer freebsd_triage 2017-01-19 15:52:07 UTC 
Committed, thanks!
Comment 9 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-01-19 16:11:26 UTC 
(In reply to Nikolai Lifanov from comment #8)
Thanks :-)
Good job ;-)