Bug 216189 - multimedia/motion - netcam's cannot connect
Summary: multimedia/motion - netcam's cannot connect
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-17 18:05 UTC by Charles P
Modified: 2017-02-18 15:17 UTC (History)
2 users (show)

See Also:

Attachments
Patch which implements upstream Github issue #287 (2.63 KB, patch)
2017-01-17 22:37 UTC, anthony 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charles P 2017-01-17 18:05:56 UTC 
[1:] [ERR] [NET] netcam_connect: connect() failed (22): Invalid argument

Fix already in upstream:

https://github.com/Motion-Project/motion/pull/287

Would be excellent if we could get a patch release to help with this :)
Comment 1 anthony 2017-01-17 22:37:53 UTC 
Created attachment 179009 [details]
Patch which implements upstream Github issue #287
Comment 2 anthony 2017-01-17 22:40:28 UTC 
I've attached a patch which implements upstream Github issue #287 against the 4.0.1 release of motion ports currently uses.

Patching carried out in a checkout of https://svn.freebsd.org/ports/head/multimedia/motion@431775.

This is my first time submitting a FreeBSD patch, so feel free to correct me on any mistakes I've inevitably made :).

Thanks,
Anthony
Comment 3 anthony 2017-01-17 22:56:09 UTC 
Should have added -- package using this patch built using poudriere, we are now using the patched version of motion in production.
Comment 4 Jason E. Hale freebsd_committer freebsd_triage 2017-01-28 11:52:02 UTC 
Looks good. I'll merge this in with changes from bug #216466. I would appreciate feedback on the other changes if you would mind taking a look.
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-01-30 00:10:07 UTC 
A commit references this bug:

Author: jhale
Date: Mon Jan 30 00:09:54 UTC 2017
New revision: 432815
URL: https://svnweb.freebsd.org/changeset/ports/432815

Log:
  - Fix an issue where netcams were not connecting [1]
  - When motion was updated to 4.x, it was overlooked that the default
    search path for the configuration files was changed. This was causing
    existing configurations to not be read. Fix the port to install
    default configuration in correct location and add an UPDATING message
    giving users the proper instructions on where to place their existing
    conf files. [2]
  - Create an empty ${ETCDIR}/conf.d directory that can optionally be used
    to dump camera configs in instead of creating separate lines for each
    one in motion.conf
  - Add some missing PORTDOCS and install with the correct mode
  - Make the VIDEO options OPTIONS_RADIO instead of OPTIONS_SINGLE to
    allow for netcam only support (suggested in [2])
  - Fix bad logic in configure.ac that was causing V4L to not be dectected
    when the PWCBSD option was enabled

  PR:		216189 [1]
  Reported by:	Charles P <charlespigott@googlemail.com>
  Patched by:	<anthony@ury.org.uk>
  Obtained from:	upstream
  PR:		216466 [2]
  Reported by:	<bakhur@inbox.ru>, tdb@
  Pointy hat to:	jhale
  MFH:		2017Q1 (blanket)

Changes:
  head/UPDATING
  head/multimedia/motion/Makefile
  head/multimedia/motion/files/motion.in
  head/multimedia/motion/files/patch-configure.ac
  head/multimedia/motion/files/patch-netcam.c
  head/multimedia/motion/files/pkg-message.in
Comment 6 Jason E. Hale freebsd_committer freebsd_triage 2017-02-18 15:17:45 UTC 
No further feedback received after r432815. Closing.