Bug 216310 - lang/python: bad links created for idle3 and pydoc3
Summary: lang/python: bad links created for idle3 and pydoc3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-20 10:48 UTC by Jose M. Alcaide
Modified: 2017-01-21 16:38 UTC (History)
0 users

See Also:
sunpoet: maintainer-feedback+


Attachments
patch for lang/python/Makefile (798 bytes, patch)
2017-01-20 10:48 UTC, Jose M. Alcaide
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jose M. Alcaide 2017-01-20 10:48:32 UTC
Created attachment 179131 [details]
patch for lang/python/Makefile

With DEFAULT_VERSIONS defined in /etc/make.conf as:

  DEFAULT_VERSIONS+=  python=3.5 python3=3.5

these idle and pydoc links are created in /usr/local/bin:

lrwxr-xr-x  1 root  wheel   9 Jan 20 10:50 /usr/local/bin/idle -> idle3-3.5
lrwxr-xr-x  1 root  wheel   7 Jan 20 10:37 /usr/local/bin/idle3 -> idle3.5
-rwxr-xr-x  1 root  wheel  99 Jan 19 16:07 /usr/local/bin/idle3.5
lrwxr-xr-x  1 root  wheel  10 Jan 20 10:50 /usr/local/bin/pydoc -> pydoc3-3.5
lrwxr-xr-x  1 root  wheel   8 Jan 20 10:37 /usr/local/bin/pydoc3 -> pydoc3.5
-rwxr-xr-x  1 root  wheel  84 Jan 19 16:07 /usr/local/bin/pydoc3.5

The idle3 and pydoc3 symlinks are created by lang/python3; idle3.5 and pydoc3.5 executables are created by lang/python35.

As it can be seen, the idle and pydoc symlinks point to non-existent filenames. The other symlinks created by lang/python (python, 2to3 and python-config) are correct.

I am sending a patch attached.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-01-20 19:39:30 UTC
A commit references this bug:

Author: sunpoet
Date: Fri Jan 20 19:38:19 UTC 2017
New revision: 431987
URL: https://svnweb.freebsd.org/changeset/ports/431987

Log:
  Fix symbolic links of idle and pydoc

  - Bump PORTREVISION for package change
  - While I'm here:
    - Remove leading definite article from COMMENT
    - Fix indent
    - Add NO_ARCH

  PR:		216310
  Submitted by:	Jose M. Alcaide <josemaria.alcaide@ehu.eus>
  MFH:		2017Q1

Changes:
  head/lang/python/Makefile
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-01-20 19:44:03 UTC
Committed. Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-01-21 16:38:57 UTC
A commit references this bug:

Author: sunpoet
Date: Sat Jan 21 16:38:07 UTC 2017
New revision: 432057
URL: https://svnweb.freebsd.org/changeset/ports/432057

Log:
  MFH: r431987

  Fix symbolic links of idle and pydoc

  - Bump PORTREVISION for package change
  - While I'm here:
    - Remove leading definite article from COMMENT
    - Fix indent
    - Add NO_ARCH

  PR:		216310
  Submitted by:	Jose M. Alcaide <josemaria.alcaide@ehu.eus>

  Approved by:	ports-secteam (junovitch)

Changes:
_U  branches/2017Q1/
  branches/2017Q1/lang/python/Makefile