Bug 216354 - audio/mixxx: fails to build with clang 4.0
Summary: audio/mixxx: fails to build with clang 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency tree / graph
 
Reported: 2017-01-21 19:07 UTC by Jan Beich
Modified: 2017-02-01 05:28 UTC (History)
1 user (show)

See Also:

Attachments
proposed patch (1008 bytes, patch)
2017-01-21 20:08 UTC, Tobias C. Berner 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2017-01-21 19:07:48 UTC 
src/widget/wdisplay.cpp:89:19: error: ordered comparison between pointer and zero ('QPixmap **' and 'int')
    if (m_pPixmaps>0)
        ~~~~~~~~~~^~

build log: http://sprunge.us/fiQC
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2017-01-21 20:08:41 UTC 
Created attachment 179191 [details]
proposed patch
Comment 2 Jan Beich freebsd_committer freebsd_triage 2017-01-21 20:56:20 UTC 
Comment on attachment 179191 [details]
proposed patch

Looks OK and builds fine[1]. Can you land it? Also on 2017Q1 with "ports-secteam blanket" since this is harmless bustage fix.

[1] 10.3 i386: http://sprunge.us/HYjZ
    /projects/clang400-import@312309 i386: http://sprunge.us/BaKb
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-02-01 05:26:06 UTC 
A commit references this bug:

Author: jbeich
Date: Wed Feb  1 05:25:29 UTC 2017
New revision: 432970
URL: https://svnweb.freebsd.org/changeset/ports/432970

Log:
  audio/mixxx: unbreak with clang 4.0

  src/widget/wdisplay.cpp:89:19: error: ordered comparison between pointer and zero ('QPixmap **' and 'int')
      if (m_pPixmaps>0)
          ~~~~~~~~~~^~

  PR:		216354
  Reported by:	antoine (via exp-run)
  Submitted by:	tcberner

Changes:
  head/audio/mixxx/files/patch-src_widget_wdisplay.cpp