Created attachment 179292 [details] Cumulative patch-Sysctl.xs file, which adds support for setting 64-bit sysctl values The attached patch supports setting 64-bit sysctl values. (Note that the patch is a complete patch-Sysctl.xs file, which includes all the changes from the existing patch-Sysctl.xs file.)
Ideally, it would be nice to have a unit test that fetched a 64-bit counter. (Skipped if the environment doesn't support it). The looks pretty good to me, unfortunately I don't have (easy) access to a machine to test that it works.
(In reply to david from comment #1) > Ideally, it would be nice to have a unit test that fetched a 64-bit counter. (Skipped if the environment doesn't support it). This patch doesn't address support for fetching 64-bit values; rather, it only addresses setting them. In that vein, you can test support for this by setting TEST_BSD_SYSCTL_NAME to a 64-bit sysctl prior to running the tests. > The looks pretty good to me, unfortunately I don't have (easy) access to a machine to test that it works. FWIW, we use this in production where I work. (I know it still would be nice to have independent verification.)
A commit references this bug: Author: swills Date: Sat Jul 8 13:45:34 UTC 2017 New revision: 445326 URL: https://svnweb.freebsd.org/changeset/ports/445326 Log: sysutils/p5-BSD-Sysctl: Support setting 64-bit sysctl values PR: 216450 Submitted by: jtl Approved by: david@landgren.net (maintainer timeout, 5 months) Changes: head/sysutils/p5-BSD-Sysctl/Makefile head/sysutils/p5-BSD-Sysctl/files/ head/sysutils/p5-BSD-Sysctl/files/patch-Sysctl.xs
Committed, thanks!