This patch updates the Widelands port to build 19. In Poudriere there's one error: ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: share/applications/widelands.desktop Although the missing file is actually present, so it seems more like a bug.
Created attachment 179306 [details] patch
The patch is broken
(In reply to Dmitry Marakasov from comment #2) What do you mean by being broken?
That there's no patch at all. > patch (35 bytes, patch)
(In reply to Dmitry Marakasov from comment #4) Strange, the patch is here: https://anongoth.pl/widelands.patch I can download it just fine.
Created attachment 182369 [details] update diff Hi, I created the attached update patch autonomously, I discovered this bug when creating a new one to submit it. The patch updates to b19. I also created a separated plist since it required a few additions for the update. Thanks!
A commit references this bug: Author: madpilot Date: Tue Jun 20 15:14:02 UTC 2017 New revision: 443985 URL: https://svnweb.freebsd.org/changeset/ports/443985 Log: - Update games/widelands to build19 PR: 216457 Submitted by: Piotr Kubaj <pkubaj@anongoth.pl> Approved by: maintainer timeout Changes: head/games/widelands/Makefile head/games/widelands/distinfo head/games/widelands/files/patch-CMakeLists.txt head/games/widelands/files/patch-cmake_WlFunctions.cmake head/games/widelands/files/patch-src-i18n.cc head/games/widelands/pkg-plist
Committed. Thanks!
Was there a reason to switch lua dependency to 5.2?
(In reply to Dmitry Marakasov from comment #9) > Was there a reason to switch lua dependency to 5.2? This is a mistake on my part actually. Thanks for catching it. The lua dependency should be removed. Starting with this release widelands seems to be using an embedded lua interpreter with no provision for using an external one. I can build it in poudriere without any lua dependencies. Can you confirm this? I should have removed it with my commit, but I admit I made a mistake leaving a test change in there. this upstream commit seems to be the one causing this: http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/revision/6829
(In reply to Guido Falsi from comment #10) > This is a mistake on my part actually. > > Thanks for catching it. > > The lua dependency should be removed. Starting with this release widelands > seems to be using an embedded lua interpreter with no provision for using an > external one. > > I can build it in poudriere without any lua dependencies. Can you confirm > this? Yes. First, I've tried to reengineer why it was needed as it built fine with 5.1, then too discovered that it's not really needed.
A commit references this bug: Author: amdmi3 Date: Mon Jul 3 15:00:46 UTC 2017 New revision: 444961 URL: https://svnweb.freebsd.org/changeset/ports/444961 Log: - Add missing depends after update to b19 - Drop unneeded lua dependency PR: 216457 Changes: head/games/widelands/Makefile