Bug 216471 - Feature request: add libx265 as default for multimedia/ffmpeg (Patch included)
Summary: Feature request: add libx265 as default for multimedia/ffmpeg (Patch included)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Thomas Zander
URL:
Keywords:
Depends on: 216473
Blocks:
  Show dependency tree / graph
 
Reported: 2017-01-25 23:23 UTC by scottro11
Modified: 2017-02-13 07:05 UTC (History)
2 users (show)

See Also:
riggs: maintainer-feedback+

Attachments
Attachment is a patch for the latest ffmpeg Makefile, adding x265 as a default (388 bytes, patch)
2017-01-25 23:23 UTC, scottro11 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description scottro11 2017-01-25 23:23:07 UTC 
Created attachment 179320 [details]
Attachment is a patch for the latest ffmpeg Makefile, adding x265 as a default

Currently, the ffmpeg port (and package) have libx265 disabled by default. As it rises in popularity, it would be nice to have it as part of the package, since currently, one can only get support for encoding to libx265 by building the port. I am attaching a patch for the ffmpeg Makefile that adds it as a default option.
Comment 1 Jan Beich freebsd_committer freebsd_triage 2017-01-26 01:24:32 UTC 
ArchLinux, Debian, Fedora (rpmfusion), Gentoo, Mageia (tainted) enable libx265 by default, so following the suit is fine. However, regressing Tier2 buildbots should be avoided as it can lead to skipping ~700 ports.

Bug 216162 comment 6 makes updates a bit scary but in ffmpeg's case only because lack of PORTREVISION bump can screw portmaster/portupgrade users.

https://abi-laboratory.pro/tracker/timeline/x265/
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-02-09 18:08:30 UTC 
A commit references this bug:

Author: riggs
Date: Thu Feb  9 18:08:15 UTC 2017
New revision: 433759
URL: https://svnweb.freebsd.org/changeset/ports/433759

Log:
  Update to upstream version 3.2.3; promote X265 to default OPTION

  Details:
  - Update to upstream version 3.2.3, bugfix release, no upstream
    feature changes
  - HEVC is becoming so widespread that it warrants promoting the
    X265 option to default [1]

  PR:		216471 [1]
  Submitted by:	scottro11@gmail.com [1]

Changes:
  head/multimedia/ffmpeg/Makefile
  head/multimedia/ffmpeg/distinfo
  head/multimedia/ffmpeg/pkg-plist
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-02-13 07:05:48 UTC 
A commit references this bug:

Author: riggs
Date: Mon Feb 13 07:05:29 UTC 2017
New revision: 433977
URL: https://svnweb.freebsd.org/changeset/ports/433977

Log:
  MFH: r433759 r433937

  Update to upstream version 3.2.3; promote X265 to default OPTION

  Details:
  - Update to upstream version 3.2.3, bugfix release, no upstream
    feature changes
  - HEVC is becoming so widespread that it warrants promoting the
    X265 option to default [1]

  PR:		216471 [1]
  Submitted by:	scottro11@gmail.com [1]

  Update to upstream version 3.2.4

  Details:
  - patch-ffserver__config.c has been upstreamed
  - Fix two potential heap overflows in lavf/mov.c

  Security:	CVE-2017-5024
  		CVE-2017-5025

  Approved by:	ports-secteam (junovitch)

Changes:
_U  branches/2017Q1/
  branches/2017Q1/multimedia/ffmpeg/Makefile
  branches/2017Q1/multimedia/ffmpeg/distinfo
  branches/2017Q1/multimedia/ffmpeg/files/patch-ffserver__config.c
  branches/2017Q1/multimedia/ffmpeg/pkg-plist