Bug 216529 - [MAINTAINER UPDATE] updating editors/codelite from 9.2 to 10.0
Summary: [MAINTAINER UPDATE] updating editors/codelite from 9.2 to 10.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nikolai Lifanov
URL: https://reviews.freebsd.org/D9362
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2017-01-27 17:34 UTC by Mahdi Mokhtari
Modified: 2017-01-31 16:09 UTC (History)
1 user (show)

See Also:

Attachments
Patch updates the port to 10.0 (3.31 KB, patch)
2017-01-27 17:34 UTC, Mahdi Mokhtari 		mmokhi: maintainer-approval+
Details | Diff
Updated diff based on latest changes on review. (3.30 KB, patch)
2017-01-27 18:01 UTC, Mahdi Mokhtari 		mmokhi: maintainer-approval+
Details | Diff
Regenerated patch based on latest change of repository (3.32 KB, patch)
2017-01-27 18:43 UTC, Mahdi Mokhtari 		mmokhi: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mahdi Mokhtari freebsd_committer freebsd_triage 2017-01-27 17:34:04 UTC 
Created attachment 179357 [details]
Patch updates the port to 10.0

The attached patch is to update the port from old 9.2 to 10.0
QA done:
    portlint is fine
    poudriere is okay
Comment 1 Nikolai Lifanov freebsd_committer freebsd_triage 2017-01-27 17:55:43 UTC 
take
Comment 2 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-01-27 18:01:33 UTC 
Created attachment 179358 [details]
Updated diff based on latest changes on review.

Deleted `PORTREVISION=0` on Makefile
Comment 3 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-01-27 18:43:14 UTC 
Created attachment 179359 [details]
Regenerated patch based on latest change of repository

The previous patch was based on r427743 the new one is based on r430796
Comment 4 Nikolai Lifanov freebsd_committer freebsd_triage 2017-01-31 14:39:18 UTC 
I saw that Matthew mention that you got a commit bit... Congrats! Would you prefer that I commit this or that you commit it yourself?
Comment 5 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-01-31 14:54:20 UTC 
(In reply to Nikolai Lifanov from comment #4)
> I saw that Matthew mention that you got a commit bit... Congrats!
Thanks :)

> Would you prefer that I commit this or that you commit it yourself?
I'd liked to do it, but I still had not received my account.
If you like you can commit it ;-) and if you leave it, I'll do it after I've received the email of my account :-D
Comment 6 Nikolai Lifanov freebsd_committer freebsd_triage 2017-01-31 16:02:32 UTC 
Committed, thanks! Also, welcome to the team!
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-01-31 16:03:01 UTC 
A commit references this bug:

Author: lifanov
Date: Tue Jan 31 16:02:07 UTC 2017
New revision: 432929
URL: https://svnweb.freebsd.org/changeset/ports/432929

Log:
  update editors/codelite to 10.0

  PR:		216529
  Submitted by:	Mahdi Mokhtari <mokhi64@gmail.com> (maintainer)
  Reviewed by:	feld, lifanov, matthew
  Approved by:	matthew (mentor)
  Differential Revision:	https://reviews.freebsd.org/D9362

Changes:
  head/editors/codelite/Makefile
  head/editors/codelite/distinfo
  head/editors/codelite/files/patch-SpellChecker_CMakeLists.txt
  head/editors/codelite/pkg-plist
Comment 8 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-01-31 16:09:01 UTC 
(In reply to Nikolai Lifanov from comment #6)
Thanks a lot :)