Bug 216600 - [New Port] devel/phpunit6: 6.0.11
Summary: [New Port] devel/phpunit6: 6.0.11
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Torsten Zuehlsdorff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-30 13:22 UTC by Jochen Neumeister
Modified: 2017-03-30 15:18 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (tz)


Attachments
Patch (926 bytes, patch)
2017-01-30 13:22 UTC, Jochen Neumeister
no flags Details | Diff
Patch (926 bytes, patch)
2017-03-01 11:06 UTC, Jochen Neumeister
no flags Details | Diff
patch (2.45 KB, patch)
2017-03-02 09:10 UTC, Jochen Neumeister
joneum: maintainer-approval+
Details | Diff
Patch (3.25 KB, patch)
2017-03-20 16:15 UTC, Jochen Neumeister
joneum: maintainer-approval+
Details | Diff
Patch (3.25 KB, patch)
2017-03-30 11:37 UTC, Jochen Neumeister
joneum: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jochen Neumeister freebsd_committer freebsd_triage 2017-01-30 13:22:46 UTC
Created attachment 179423 [details]
Patch

poudriere build fine for:
10.3 amd + i386
11.0 amd + i386
12-current amd + i386 (r310257)

portlint -AC is also fine.


Cheers
jochen
Comment 1 Jochen Neumeister freebsd_committer freebsd_triage 2017-03-01 11:06:40 UTC
Created attachment 180388 [details]
Patch

Update this port to Version 6.0.7

make test is fine.

poudriere build fine for:
9.3 amd + i386
10.3 amd + i386
12-current amd + i386 (r313761)

portlint is also fine.


Cheers
jochen
Comment 2 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-03-01 17:25:33 UTC
I updated phpunit to 5.7.14, the latest stable release.

For phpunit 6.x i would like to create a new port. It only supports PHP 7, which could be a problem since PHP 5.6.x is still our default php version. Or we lift our default PHP version. Do you want to find out how this is done? ;)

Greetings,
Torsten
Comment 3 Jochen Neumeister freebsd_committer freebsd_triage 2017-03-02 09:10:43 UTC
Created attachment 180425 [details]
patch

Hi Torsten,

Here is the first design for the new port. I called him phpunit6. He should use php7. Can you look at it, and give me a feedback what needs to be improved? Thank you! :-)

I tested with poudriere and "make test".

Cheers
Jochen
Comment 4 Jochen Neumeister freebsd_committer freebsd_triage 2017-03-02 11:43:03 UTC
A new Version is available: 4.7.1

I will check it.
Comment 5 Jochen Neumeister freebsd_committer freebsd_triage 2017-03-02 11:43:24 UTC
(In reply to Jochen Neumeister from comment #4)

args .... wrong PR
Comment 6 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-03-20 14:18:24 UTC
Currently 6.0.10 is the most recent version. o.O

As a first comment: you're tabs can't decide how far the should go. :D I often do a "cat Makefile" because many editors do not render tabs correctly. The rest seems straightforward and good.

+# $FreeBSD$
+
+PORTNAME=		phpunit
+PORTVERSION=	6.0.7
+CATEGORIES=		devel www
+MASTER_SITES=	https://phar.phpunit.de/
+EXTRACT_SUFX=	.phar
+
+MAINTAINER=		joneum@bsdproject.de
+COMMENT=		Testing framework for unit tests
+
Comment 7 Jochen Neumeister freebsd_committer freebsd_triage 2017-03-20 16:15:23 UTC
Created attachment 181004 [details]
Patch

Hi,

here is a new Patch for PHPUnit6 with ignore PHP Version 56.

Modified Makefile devel/phpunit (Ignored PHP7 and Portscout)
Comment 8 Jochen Neumeister freebsd_committer freebsd_triage 2017-03-30 11:37:35 UTC
Created attachment 181311 [details]
Patch
Comment 9 commit-hook freebsd_committer freebsd_triage 2017-03-30 14:08:10 UTC
A commit references this bug:

Author: tz
Date: Thu Mar 30 14:07:29 UTC 2017
New revision: 437295
URL: https://svnweb.freebsd.org/changeset/ports/437295

Log:
  New port: devel/phpunit6

  PHPUnit is a regression testing framework used by the developer
  who implements unit tests in PHP.

  WWW: http://www.phpunit.de

  This port needs PHP 7.0 or newer, while the old one devel/phpunit
  will still work at our current default PHP 5.6.

  PR:           216600
  Submitted by: Jochen Neumeister <joneum@bsdproject.de>

Changes:
  head/devel/Makefile
  head/devel/phpunit6/
  head/devel/phpunit6/Makefile
  head/devel/phpunit6/distinfo
  head/devel/phpunit6/pkg-descr
Comment 10 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-03-30 14:12:09 UTC
Aloha Jochen,

do get the PR closed i refactored it myself. The tab usage in the Makefile wasn't good. ;) Just do a "cat Makefile" and look if most of it adjust. There is no need for orienting at outstanding lines, if they are exceptions.

Also for new ports please create a shar and not a diff. I now you can do it, so i just converted it myself to save us time. :)

Thanks for the new port! :)

Greetings,
Torsten
Comment 11 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-03-30 14:16:31 UTC
Oh, forgot to mention: i removed the CONFLICT line, since there is no port left matching this name. :)
Comment 12 Jochen Neumeister freebsd_committer freebsd_triage 2017-03-30 15:18:47 UTC
(In reply to Torsten Zuehlsdorff from comment #11)

thank you for the tipps. I will consider them next time.

About devel/phpunit: This Port doesn't build with PHP7.

Is not it sensible to write that into the makefile?