Bug 216639 - games/d2x-xl: fails to build with clang 4.0
Summary: games/d2x-xl: fails to build with clang 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency tree / graph
 
Reported: 2017-01-30 23:58 UTC by Jan Beich
Modified: 2017-02-27 13:51 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (aragon)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2017-01-30 23:58:53 UTC 
reactor.cpp:187:34: error: ordered comparison between pointer and zero ('fix *' (aka 'int *') and 'int')
if (trigP && (trigP->m_info.time > 0))
              ~~~~~~~~~~~~~~~~~~ ^ ~

build log: http://package18.nyi.freebsd.org/data/headamd64PR216008-default/2017-01-29_16h09m05s/logs/errors/d2x-xl-1.14.121_9.log
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-02-27 13:51:47 UTC 
A commit references this bug:

Author: amdmi3
Date: Mon Feb 27 13:51:28 UTC 2017
New revision: 434937
URL: https://svnweb.freebsd.org/changeset/ports/434937

Log:
  - Switch to USES=autoreconf
  - Fix build with clang 4.0 (

  PR:		216639
  Reported by:	jbeich@FreeBSD.org
  Approved by:	maintainer timeout (aragon@phat.za.net, 4 weeks)

Changes:
  head/games/d2x-xl/Makefile
  head/games/d2x-xl/files/patch-objects_reactor.cpp