Bug 216846 - security/sslsplit: add LICENSE, USES=ssl, strip the binary, fix build with libressl-devel
Summary: security/sslsplit: add LICENSE, USES=ssl, strip the binary, fix build with li...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-06 13:53 UTC by Piotr Kubaj
Modified: 2017-04-07 17:25 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (swills)


Attachments
patch (2.18 KB, patch)
2017-02-06 13:53 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2017-02-06 13:53:14 UTC
Created attachment 179676 [details]
patch

The port previously failed with:
ssl.c:480:21: error: no member named 'state' in 'struct ssl_st'
cc -c  -isystem/usr/local/include   -D_GNU_SOURCE -D"BNAME=\"sslsplit\"" -D"PNAME=\"SSLsplit\"" -D"VERSION=\"0.5.0\"" -D"BUILD_DATE=\"2017-02-06\"" -D"FEATURES=\"-DHAVE_IPFILTER -DHAVE_IPFW -DHAVE_PF\"" -D"BUILD_INFO=\"V:FILE\"" -DHAVE_IPFILTER -DHAVE_IPFW -DHAVE_PF -O2 -pipe  -DHARDENEDBSD -fPIE -fPIC -fstack-protector -fno-strict-aliasing -D_THREAD_SAFE -pthread   -std=c99 -Wall -Wextra -pedantic -D_FORTIFY_SOURCE=2 -fstack-protector-all -pthread -o version.o version.c
                      ssl->state,
                      ~~~  ^
ssl.c:481:22: error: no member named 'state' in 'struct ssl_st'
                      (ssl->state & SSL_ST_CONNECT) ? "SSL_ST_CONNECT|" : "",
                       ~~~  ^
ssl.c:482:22: error: no member named 'state' in 'struct ssl_st'
                      (ssl->state & SSL_ST_ACCEPT) ? "SSL_ST_ACCEPT|" : "",
                       ~~~  ^
ssl.c:483:22: error: no member named 'state' in 'struct ssl_st'
                      (ssl->state & SSL_ST_BEFORE) ? "SSL_ST_BEFORE|" : "",
                       ~~~  ^
ssl.c:484:21: error: no member named 'state' in 'struct ssl_st'
                      ssl->state & SSL_ST_MASK,
                      ~~~  ^
ssl.c:487:22: error: no member named 'type' in 'struct ssl_st'
                      (ssl->type == SSL_ST_CONNECT) ? "connect socket"
                       ~~~  ^


This patch fixes this issue.
Tested on Poudriere on 10.3-RELEASE with and without libressl-devel.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-04-07 17:24:08 UTC
A commit references this bug:

Author: swills
Date: Fri Apr  7 17:23:23 UTC 2017
New revision: 437947
URL: https://svnweb.freebsd.org/changeset/ports/437947

Log:
  security/sslsplit: fix build with libressl-devel

  While here, add LICENSE, USES=ssl, strip the binary

  PR:		216846
  Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>

Changes:
  head/security/sslsplit/Makefile
  head/security/sslsplit/files/patch-ssl.c
Comment 2 Steve Wills freebsd_committer freebsd_triage 2017-04-07 17:25:48 UTC
Committed, thanks!