Created attachment 179863 [details] patch file Update ibus to 1.5.14 from 1.5.11. Major changes: * Installed dbus service file * Emoji input Originally, this depends on nodejs-emojione. However, this is not ported, and the whole distribution file is large (95M), while only one small file is needed. In this port, the corresponding file is grabbed from github.
Created attachment 179864 [details] poudriere log
Created attachment 180062 [details] update diff Hi, I'm still testing the update, I'm checking dependent ports. In the while I'd like you to review a few changes I made to your submission. - I fixed the logic for having multiple distfiles, like indicated here: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.htmlporting-master-sites-n - Converted the port to using USES=localbase - Using the <OPTION>_IMPLIES functionality instead of marking the port BROKEN. This is documented in the bsd.options.mk file - Also used <OPTION>_VAR helper to simplify the Makefile and reworked the whole EMOJI option check to use option helpers, and also an option target, instead of conditionals. Can you approve these changes? Thanks!
Comment on attachment 180062 [details] update diff Please commit it. I never know that there are so many variables in the new options framework. I should have a look.
A commit references this bug: Author: madpilot Date: Sun Feb 26 08:54:34 UTC 2017 New revision: 434850 URL: https://svnweb.freebsd.org/changeset/ports/434850 Log: - Update textproc/ibus to 1.5.14 - Add EMOJI option - Convert to USES localbase - Use more option helpers PR: 216991 Submitted by: Henry Hu <henry.hu.sh@gmail.com> (maintainer) Approved by: maintainer Changes: head/textproc/ibus/Makefile head/textproc/ibus/distinfo head/textproc/ibus/pkg-plist
Committed! Thanks.