Bug 217150 - net/bird: cf-parse.y: error: too many arguments to function call
Summary: net/bird: cf-parse.y: error: too many arguments to function call
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Olivier Cochard
URL:
Keywords:
: 217151 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-02-16 19:38 UTC by O. Hartmann
Modified: 2017-05-29 19:37 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (melifaro)

Attachments
Fixing bird firewall patch compilation (2.53 KB, patch)
2017-04-28 14:51 UTC, Olivier Cochard 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description O. Hartmann 2017-02-16 19:38:02 UTC 
The port net/bird (as well as net/bird6) is miscompiling on CURRENT (jail OSVERSION: 1200020) is miscompiling now for a very long time (since last year). Build environment is a poudriere jail (Poudriere version: 3.1.14).

The port build fails with:


[...]
cf-parse.y:3491:25: warning: assigning to 'byte *' (aka 'unsigned char *') from 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
      this_srt->if_name = (yyvsp[0].t);
                        ^ ~~~~~~~~~~~~
cf-parse.y:3533:85: error: too many arguments to function call, expected 2, have 3
     this_proto = proto_config_new(&proto_firewall, sizeof(struct firewall_config), (yyvsp[-1].i));
                  ~~~~~~~~~~~~~~~~                                                  ^~~~~~~~~~~~~
../../nest/protocol.h:248:1: note: 'proto_config_new' declared here
void *proto_config_new(struct protocol *, int class);
^
4 warnings and 1 error generated.
Comment 1 Olivier Cochard freebsd_committer freebsd_triage 2017-04-27 22:40:10 UTC 
I don't reach to reproduce your problem:
Against a 12.0-CURRENT r317435, poudriere testport didn't meet any problem.

http://dev.bsdrp.net/poudriere/120amd64-default/bird-1.6.3_1.log
http://dev.bsdrp.net/poudriere/120amd64-default/bird6-1.6.3_1.log
Comment 2 Walter Schwarzenfeld 2017-04-28 03:12:18 UTC 
The error appears if FIREWALL is on.
Comment 3 Olivier Cochard freebsd_committer freebsd_triage 2017-04-28 14:51:35 UTC 
Created attachment 182161 [details]
Fixing bird firewall patch compilation

Here is a patch that should fix compilation, but I need someone to review and test it.
This patch ask bird rc scripts to create a pid file too by default.
Comment 4 Olivier Cochard freebsd_committer freebsd_triage 2017-04-28 14:53:55 UTC 
*** Bug 217151 has been marked as a duplicate of this bug. ***
Comment 5 Walter Schwarzenfeld 2017-04-28 15:15:12 UTC 
Seems to work. Compiles now fine. Thanks!
Comment 6 Olivier Cochard freebsd_committer freebsd_triage 2017-04-28 15:21:10 UTC 
(In reply to w.schwarzenfeld from comment #5)

Yes it compiles, but does it works ? :-)
Comment 7 Walter Schwarzenfeld 2017-04-28 16:33:49 UTC 
I don't work without. I am only looked in it (found only the half of your solution
;))).
You have to wait for the answer of O.Hartmann.
Comment 8 Walter Schwarzenfeld 2017-04-28 16:34:23 UTC 
Typo: I don't work with it.
Comment 9 O. Hartmann 2017-04-29 08:16:15 UTC 
Yet I don't work with it, either. It is part of the set of software (amongst zebra) we are preparing for a selfmade router/firewall. 

So far in my case, poudriere builds both, bird and bird6, packages right now, thanks.
Comment 10 Olivier Cochard freebsd_committer freebsd_triage 2017-04-29 10:47:48 UTC 
I will wait for maintainer reply before commit this change, then close this PR.
Comment 11 commit-hook freebsd_committer freebsd_triage 2017-05-29 19:31:24 UTC 
A commit references this bug:

Author: olivier
Date: Mon May 29 19:30:31 UTC 2017
New revision: 442031
URL: https://svnweb.freebsd.org/changeset/ports/442031

Log:
  Fix MD5 TCP signature usage with latest tcpmd5 kernel module

  PR:		21890
  Submitted by:	ae
  Reported by:	Joseph Mulloy <freebsd-bugs@joe.mulloy.me>
  Approved by:	melifaro (maintainer)

  Fix build with option FIREWALL

  PR:		217150
  Submitted by:	olivier
  Reported by:	O. Hartmann <ohartmann@walstatt.org>
  Approved by:	melifaro (maintainer)
  Sponsored by:	Orange

Changes:
  head/net/bird/Makefile
  head/net/bird/files/bird.in
  head/net/bird/files/bird6.in
  head/net/bird/files/firewall_support.patch
  head/net/bird/files/patch-sysdep-bsd-setkey.h
Comment 12 Olivier Cochard freebsd_committer freebsd_triage 2017-05-29 19:37:00 UTC 
Patch commited