Bug 217411 - emulators/qemu-user-static: build fails on 10.x
Summary: emulators/qemu-user-static: build fails on 10.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Sean Bruno
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-28 00:57 UTC by John Hein
Modified: 2017-05-09 12:27 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sbruno)

Attachments
[patch] fix build error on 10.x (413 bytes, patch)
2017-02-28 07:00 UTC, John Hein 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2017-02-28 00:57:16 UTC 
qemu-user-static fails to build after recent qemu-sbruno update:


 .
 .
cc -I/usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14/tcg -I/usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14/tcg/i386 -I. -I/usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14 -I/usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14/include -I/usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14/bsd-user/freebsd -Ibsd-user/freebsd -I/usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14/dtc/libfdt -pthread -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include  -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv  -I/usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14 -I/usr/local/include -DPREFIX=\""/usr/local\"" -Wno-string-plus-int -Wno-initializer-overrides -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-definition -Wtype-limits -fstack-protector-all -I/usr/local/include  -I.. -I/usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14/target/i386 -DNEED_CPU_H -I/usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14/include -I/usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14/bsd-user -I/usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14/bsd-user/x86_64 -I/usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14/bsd-user/freebsd -MMD -MP -MT bsd-user/freebsd/os-sys.o -MF bsd-user/freebsd/os-sys.d -g -O2 -pipe  -fstack-protector -fno-strict-aliasing  -c -o bsd-user/freebsd/os-sys.o /usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14/bsd-user/freebsd/os-sys.c
/usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14/bsd-user/freebsd/os-sys.c:753:32: error: /usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14/bsd-user/freebsd/os-sys.c:753:32: error: no member named 'ifi_oqdrops' in 'struct if_data'; did you mean 'ifi_iqdrops'?
            PUT(tifm->ifm_data.ifi_oqdrops, ifm->ifm_data.ifi_oqdrops);
                               ^~~~~~~~~~~
                               ifi_iqdrops
/usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14/bsd-user/freebsd/os-sys.c:575:32: note: expanded from macro 'PUT'
#define PUT(t,v) switch(sizeof(t)) {   \
                               ^
no member named 'ifi_oqdrops' in 'struct if_data'; did you mean 'ifi_iqdrops'?/usr/include/net/if.h:104:9: note: 'ifi_iqdrops' declared here
        u_long  ifi_iqdrops;            /* dropped on input, this interface */
                ^
/usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14/bsd-user/freebsd/os-sys.c:753:32: error: no member named 'ifi_oqdrops' in 'struct if_data'; did you mean 'ifi_iqdrops'?

            PUT(tifm->ifm_data.ifi_oqdrops, ifm->ifm_data.ifi_oqdrops);
                               ^~~~~~~~~~~
                               ifi_iqdrops
/usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-f51cf14/bsd-user/freebsd/os-sys.c:575:32: note: expanded from macro 'PUT'
#define PUT(t,v) switch(sizeof(t)) {   \
                               ^
/usr/include/net/if.h:104:9: note            PUT(tifm->ifm_data.ifi_oqdrops, ifm->ifm_data.ifi_oqdrops);
                               ^~~~~~~~~~~
                               ifi_iqdrops

 .
 .
Comment 1 John Hein 2017-02-28 07:00:56 UTC 
Created attachment 180355 [details]
[patch] fix build error on 10.x

This patch fixes the build on 10.x.  I could have made it dependent on OSVERSION, but it doesn't hurt to define the flag for other versions and is the simplest fix.  It can be removed once 10.x goes away.
Comment 2 Walter Schwarzenfeld 2017-02-28 07:37:28 UTC 
Thanks, this fixes the problem.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-03-01 22:08:42 UTC 
A commit references this bug:

Author: sbruno
Date: Wed Mar  1 22:08:29 UTC 2017
New revision: 435203
URL: https://svnweb.freebsd.org/changeset/ports/435203

Log:
  Add configure arg to fix build on 10.x

  PR:	217411
  Submitted by:	John Hein <z7dr6ut7gs@snkmail.com>

Changes:
  head/emulators/qemu-user-static/Makefile
Comment 4 John Hein 2017-05-09 12:27:06 UTC 
Fixed in https://svnweb.freebsd.org/changeset/ports/435203
The bug was not automatically closed for some reason.  Closing it now.