Bug 217464 - mail/neomutt: Enable SLANG support
Summary: mail/neomutt: Enable SLANG support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-01 21:28 UTC by Kirill Ponomarev
Modified: 2017-03-12 14:29 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bapt)

Attachments
neomutt patch (1.57 KB, patch)
2017-03-01 21:28 UTC, Kirill Ponomarev 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kirill Ponomarev freebsd_committer freebsd_triage 2017-03-01 21:28:36 UTC 
Created attachment 180403 [details]
neomutt patch

Compiling mutt against ncurses doesn't provide proper colors handling on Mac, especially you notice it in iTerm on Mac with solarized theme. You can use with SLANG 256 colorized version instead of 16 colours for ncurses. I suspect ncurses on Mac are outdated and/or unmaintained, so Terminal and iTerm handle terminfo in bad way.

I've created SLANG support and left NCURSES switched on by default.
Comment 1 Baptiste Daroussin freebsd_committer freebsd_triage 2017-03-01 21:46:38 UTC 
What is the value of $TERM on your mac? I think the only issue with ncurses is some missing entries in the terminfo database probably
Comment 2 Kirill Ponomarev freebsd_committer freebsd_triage 2017-03-01 21:52:44 UTC 
It's xterm-256color.

That's right, because of outdated and old ncurses which handles not properly terminfo most of Mac users are convinced to live with it, proving SLANG support at least can make life not so bitter for them.
Comment 3 Kirill Ponomarev freebsd_committer freebsd_triage 2017-03-07 07:45:01 UTC 
Baptiste, what will we do with this one? Are you going to commit it in next release or we just close it?
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-03-12 14:28:37 UTC 
A commit references this bug:

Author: bapt
Date: Sun Mar 12 14:28:26 UTC 2017
New revision: 435988
URL: https://svnweb.freebsd.org/changeset/ports/435988

Log:
  Update to 2017-03-06
  Add an option for slang support[1]

  PR:		217464, 212292
  Submitted by:	krion, pi

Changes:
  head/mail/neomutt/Makefile
  head/mail/neomutt/distinfo
  head/mail/neomutt/files/patch-getdomain.c
  head/mail/neomutt/files/pkg-message.slang