Bug 217570 - devel/ccache: simlinks not removed by ccache-update-links
Summary: devel/ccache: simlinks not removed by ccache-update-links
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-05 22:38 UTC by rwmaillists
Modified: 2017-03-06 17:50 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bdrewery)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description rwmaillists 2017-03-05 22:38:26 UTC 
ccache-update-links adds new symlinks for installed compilers, but fails to remove obsolete links when compilers are deinstalled. 

The reason appears to be that "command -v" is finding the symlink to ccache when it looks for the actual compiler.
Comment 1 Bryan Drewery freebsd_committer freebsd_triage 2017-03-06 03:30:41 UTC 
Can you test this patch please? https://people.freebsd.org/~bdrewery/patches/ccache-links.patch
Comment 2 rwmaillists 2017-03-06 12:28:56 UTC 
The patch works for me. Thanks.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-03-06 17:50:27 UTC 
A commit references this bug:

Author: bdrewery
Date: Mon Mar  6 17:50:15 UTC 2017
New revision: 435560
URL: https://svnweb.freebsd.org/changeset/ports/435560

Log:
  ccache-update-links.sh: Fix removing links to missing compilers.

  PR:		217570
  Reported by:	rwmaillists@googlemail.com
  Tested by:	rwmaillists@googlemail.com

Changes:
  head/devel/ccache/Makefile
  head/devel/ccache/files/ccache-update-links.sh.in
Comment 4 Bryan Drewery freebsd_committer freebsd_triage 2017-03-06 17:50:35 UTC 
Thanks for the report and testing!