Bug 218295 - irc/ircII: obsolete patch in port breaks logging
Summary: irc/ircII: obsolete patch in port breaks logging
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-01 19:24 UTC by Andrew "RhodiumToad" Gierth
Modified: 2017-04-01 21:00 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (adamw)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew "RhodiumToad" Gierth 2017-04-01 19:24:14 UTC 
patch-source_window.c was apparently added to fix a logging issue in 20141122. However, 20151120 fixes the same issue in a different way, and the now-obsolete patch file is not removed from the port, so the patch _breaks_ logging rather than fixing it.

To reproduce: with no other options configured, use /set logfile irc.log  and  /set log on  to enable logging, join a channel and talk, observe that nothing is logged except messages not directed to any window.

To fix: remove files/patch-source_window.c
Comment 1 Adam Weinberger freebsd_committer freebsd_triage 2017-04-01 19:46:19 UTC 
You're absolutely right, Andrew.

I don't use ircII anymore. Would you like to maintain the port?
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-04-01 20:31:34 UTC 
A commit references this bug:

Author: adamw
Date: Sat Apr  1 20:31:18 UTC 2017
New revision: 437473
URL: https://svnweb.freebsd.org/changeset/ports/437473

Log:
  MFH: r437472

  Unbreak logging by removing a stale patch (which, once upon a time,
  fixed logging) which wound up re-breaking logging after logging was
  fixed upstream.

  I don't use this anymore, so I'm donating it back to ports@.

  PR:		218295
  Submitted by:	andrew tao11 riddles org uk
  Approved by:	portmgr (self)

Changes:
_U  branches/2017Q2/
  branches/2017Q2/irc/ircII/Makefile
  branches/2017Q2/irc/ircII/files/patch-source_window.c
Comment 3 Adam Weinberger freebsd_committer freebsd_triage 2017-04-01 20:33:11 UTC 
Fixed in r437472 (forgot to link the PR in that commit, sorry Andrew), and merged to quarterly. I'm closing the PR but if you'd like to take maintainership of the port, send me an email or reopen the PR.
Comment 4 Andrew "RhodiumToad" Gierth 2017-04-01 20:45:32 UTC 
I guess I'll take the maintainership on in the absence of some other victim...
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-04-01 20:57:56 UTC 
A commit references this bug:

Author: adamw
Date: Sat Apr  1 20:56:55 UTC 2017
New revision: 437479
URL: https://svnweb.freebsd.org/changeset/ports/437479

Log:
  Pass maintainership to submitter.

  PR:		218295
  Submitted by:	andrew tao11 riddles org uk

Changes:
  head/irc/ircII/Makefile
Comment 6 Adam Weinberger freebsd_committer freebsd_triage 2017-04-01 21:00:08 UTC 
Done. Thanks, Andrew. Feel free to Cc me on future PRs for ircII.