Bug 218297 - editors/codelite: Set correct includepath if devel/check is installed (cause of check.h)
Summary: editors/codelite: Set correct includepath if devel/check is installed (cause ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mahdi Mokhtari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-01 22:32 UTC by Walter Schwarzenfeld
Modified: 2018-01-18 11:42 UTC (History)
0 users

See Also:
mmokhi: maintainer-feedback+
sunpoet: maintainer-feedback-


Attachments
patch-sdk__codelite_cppcheck__CMakeLists_txt (545 bytes, patch)
2017-05-01 21:03 UTC, Walter Schwarzenfeld
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Walter Schwarzenfeld 2017-04-01 22:32:57 UTC
Codelite 10.0.1 fails to compile with:

--- sdk/codelite_indexer/CMakeFiles/codelite_indexer.dir/libctags/fortran.c.o ---
--- sdk/codelite_cppcheck/CMakeFiles/codelite_cppcheck.dir/all ---
--- sdk/codelite_cppcheck/CMakeFiles/codelite_cppcheck.dir/cli/cmdlineparser.cpp.o ---
In file included from /ram/usr/ports/editors/codelite/work/codelite-10.0/sdk/codelite_cppcheck/cli/cmdlineparser.cpp:26:
/usr/local/include/check.h:686:37: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
  "Assertion '%s' failed: %s == %.*"TM"g, %s == %.*"TM"g", \
                                    ^
                                     
/usr/local/include/check.h:686:53: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
  "Assertion '%s' failed: %s == %.*"TM"g, %s == %.*"TM"g", \
                                                    ^
                                                     
/usr/local/include/check.h:698:39: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
    "Assertion '%s' failed: %s == %.*"TM"g", \
                                      ^
                                       
/usr/local/include/check.h:709:39: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
    "Assertion '%s' failed: %s == %.*"TM"g", \
                                      ^
                                       
/usr/local/include/check.h:720:39: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
    "Assertion '%s' failed: %s == %.*"TM"g", \
                                      ^
                                       
/usr/local/include/check.h:731:39: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
    "Assertion '%s' failed: %s == %.*"TM"g", \
                                      ^
                                       
/usr/local/include/check.h:744:37: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
  "Assertion '%s' failed: %s == %.*"TM"g, %s == %.*"TM"g, %s == %.*"TM"g", \
                                    ^
                                     
/usr/local/include/check.h:744:53: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
  "Assertion '%s' failed: %s == %.*"TM"g, %s == %.*"TM"g, %s == %.*"TM"g", \
                                                    ^
                                                     
/usr/local/include/check.h:744:69: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
  "Assertion '%s' failed: %s == %.*"TM"g, %s == %.*"TM"g, %s == %.*"TM"g", \
                                                                    ^
                                                                     
/usr/local/include/check.h:760:39: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
    "Assertion '%s' failed: %s == %.*"TM"g, %s == %.*"TM"g, %s == %.*"TM"g", \
                                      ^
                                       
/usr/local/include/check.h:760:55: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
--- sdk/codelite_indexer/CMakeFiles/codelite_indexer.dir/all ---
[  5%] Building C object sdk/codelite_indexer/CMakeFiles/codelite_indexer.dir/libctags/fortran.c.o
--- sdk/codelite_cppcheck/CMakeFiles/codelite_cppcheck.dir/all ---
    "Assertion '%s' failed: %s == %.*"TM"g, %s == %.*"TM"g, %s == %.*"TM"g", \
                                                      ^
                                                       
/usr/local/include/check.h:760:71: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
    "Assertion '%s' failed: %s == %.*"TM"g, %s == %.*"TM"g, %s == %.*"TM"g", \

(10.3-amd64)
Comment 1 Walter Schwarzenfeld 2017-04-01 22:59:33 UTC
Works if I removed devel/check (/usr/local/include/check.h).
Comment 2 Walter Schwarzenfeld 2017-04-02 00:16:25 UTC
/usr/local/include/check.h:

all appearances of  "TM" must changed to " TM ".
Comment 3 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-04-02 12:30:28 UTC
So in case you believe the problem is with devel/check, I'll CC sunpoet@ here too.
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-04-02 13:21:10 UTC
(In reply to w.schwarzenfeld from comment #1)

That means the build process picked up the wrong check.h. You should fix the include path to use check.h in codelite source instead of that in /usr/local/include.
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-04-02 13:46:57 UTC
The correct one:

% ls -la sdk/codelite_cppcheck/lib/check.h
-rw-r--r--  1 root     wheel  4660 Jan  2 16:08 sdk/codelite_cppcheck/lib/check.h
Comment 6 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-04-02 13:58:54 UTC
(In reply to Po-Chuan Hsieh from comment #5)
Okay, thanks for info, gonna take a deeper look on it.
Comment 7 Walter Schwarzenfeld 2017-04-02 17:29:01 UTC
I don't know if you can repeat the error.
Yesterday codelite update was part of a "big" update with gcc5 and four llvm compilers.
Yesterday I could repeat the error. Today not, it seems solved. Maybe, it was something during this update. Please, tell me if I should close here.
Comment 8 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-04-02 17:32:54 UTC
(In reply to w.schwarzenfeld from comment #7)
Thanks for additional info.
I'll try to build codelite on latest tree with all combinantion of options.
If I could not reproduce the error, I'll close PR as 'not a bug'

Regards.
Comment 9 Walter Schwarzenfeld 2017-05-01 16:05:28 UTC
Seems my last statement was wrong. The error still exists.
Comment 10 Walter Schwarzenfeld 2017-05-01 20:57:58 UTC
Found it:
Got it to compile if I add to
sdk/codelite_cppcheck/CMakeLists.txt
set (CMAKE_INCLUDE_DIRECTORIES ON)
include_directories(BEFORE "${CL_SRC_ROOT}/sdk/codelite_cppcheck/lib" )
Comment 11 Walter Schwarzenfeld 2017-05-01 21:03:20 UTC
Created attachment 182235 [details]
patch-sdk__codelite_cppcheck__CMakeLists_txt
Comment 12 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-05-02 11:11:29 UTC
(In reply to w.schwarzenfeld from comment #10)
Oh great!
I was still more-or-less digging for it.
Thanks for speeding up ;-] great job.

I'll apply/test the patch tonight :D
Comment 13 Walter Schwarzenfeld 2017-05-19 14:10:12 UTC
ping!
Comment 14 Walter Schwarzenfeld 2018-01-17 15:11:36 UTC
Hello! Forgotten?
Comment 15 commit-hook freebsd_committer freebsd_triage 2018-01-18 11:16:39 UTC
A commit references this bug:

Author: mmokhi
Date: Thu Jan 18 11:16:24 UTC 2018
New revision: 459322
URL: https://svnweb.freebsd.org/changeset/ports/459322

Log:
  editors/codelite: Fix build when devel/check is installed.
  Set correct include-path if devel/check is installed for check.h

  PR:		218297
  Submitted by:	w.schwarzenfeld@utanet.at
  Reported by:	w.schwarzenfeld@utanet.at

Changes:
  head/editors/codelite/files/
  head/editors/codelite/files/patch-sdk_codelite__cppcheck_CMakeLists.txt
Comment 16 Mahdi Mokhtari freebsd_committer freebsd_triage 2018-01-18 11:42:29 UTC
Committed.
Thanks :)