Bug 218335 - [dns/bind911] [patch] unbreak rndc.key handling for service stop/reload
Summary: [dns/bind911] [patch] unbreak rndc.key handling for service stop/reload
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mathieu Arnold
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-04-03 16:10 UTC by Eugene Grosbein
Modified: 2017-04-13 10:17 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mat)

Attachments
setup rndc_flags (1.38 KB, patch)
2017-04-03 16:10 UTC, Eugene Grosbein 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Grosbein freebsd_committer freebsd_triage 2017-04-03 16:10:31 UTC 
Created attachment 181434 [details]
setup rndc_flags

In case of non-default path to rndc.key (f.e. /etc/namedb/rndc.key) current service startup script may fail to construct correct rndc_flags variable for "stop" or "reload" actions. As a result, service named stop/reload fail to manage daemon with rndc command and forcebly kill it and restart.

On the other hand, it correctly setups rndc_flags in prestart function when this is unneeded. Proposed patch fixes this.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-04-13 10:15:39 UTC 
A commit references this bug:

Author: mat
Date: Thu Apr 13 10:15:19 UTC 2017
New revision: 438434
URL: https://svnweb.freebsd.org/changeset/ports/438434

Log:
  Unbreak rndc calls when using non default rndc.key location.

  PR:		218335
  Sponsored by:	Absolight

Changes:
  head/dns/bind9-devel/Makefile
  head/dns/bind9-devel/files/named.in
  head/dns/bind910/Makefile
  head/dns/bind910/files/named.in
  head/dns/bind911/Makefile
  head/dns/bind911/files/named.in
  head/dns/bind99/Makefile
  head/dns/bind99/files/named.in
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-04-13 10:17:42 UTC 
A commit references this bug:

Author: mat
Date: Thu Apr 13 10:17:09 UTC 2017
New revision: 438436
URL: https://svnweb.freebsd.org/changeset/ports/438436

Log:
  MFH: r438434

  Unbreak rndc calls when using non default rndc.key location.

  PR:		218335
  Sponsored by:	Absolight

Changes:
_U  branches/2017Q2/
  branches/2017Q2/dns/bind9-devel/Makefile
  branches/2017Q2/dns/bind9-devel/files/named.in
  branches/2017Q2/dns/bind910/Makefile
  branches/2017Q2/dns/bind910/files/named.in
  branches/2017Q2/dns/bind911/Makefile
  branches/2017Q2/dns/bind911/files/named.in
  branches/2017Q2/dns/bind99/Makefile
  branches/2017Q2/dns/bind99/files/named.in