Bug 218370 - net/socat: add READLINE option
Summary: net/socat: add READLINE option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-04 14:27 UTC by Po-Chuan Hsieh
Modified: 2017-04-10 09:50 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)

Attachments
patch (668 bytes, patch)
2017-04-04 14:27 UTC, Po-Chuan Hsieh 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-04-04 14:27:38 UTC 
Created attachment 181476 [details]
patch

Add READLINE option

- Bump PORTREVISION for dependency and package change

====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/filan is linked to /usr/local/lib/libreadline.so.6 from devel/readline but it is not declared as a dependency
Warning: you need USES+=readline
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-04-10 09:48:08 UTC 
A commit references this bug:

Author: ehaupt
Date: Mon Apr 10 09:47:24 UTC 2017
New revision: 438139
URL: https://svnweb.freebsd.org/changeset/ports/438139

Log:
  socat will automatically link against readline if devel/readline is installed.
  Make readline optional and explicitly enable/disable during configure. This
  did not affect pkg only users as readline is not present on package build
  clusters but might affect (depending on readline presence) users that manually
  build ports. Therefore bump PORTREVISION.

  PR:		218370 (based on)
  Submitted by:	sunpoet

Changes:
  head/net/socat/Makefile
Comment 2 Emanuel Haupt freebsd_committer freebsd_triage 2017-04-10 09:49:18 UTC 
Committed with minor modifications, thanks!

Modifications:
configure needs to be told to disable readline if readline option is not selected otherwise it will still link against readline if present.