Bug 218526 - www/serendipity: Update to 2.1.1
Summary: www/serendipity: Update to 2.1.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Torsten Zuehlsdorff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-10 09:40 UTC by Jochen Neumeister
Modified: 2017-05-03 15:07 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (tz)

Attachments
Patch (20.16 KB, patch)
2017-04-10 09:40 UTC, Jochen Neumeister 		no flags Details | Diff
Patch (20.05 KB, patch)
2017-04-12 14:46 UTC, Jochen Neumeister 		joneum: maintainer-approval? (tz)
 Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jochen Neumeister freebsd_committer freebsd_triage 2017-04-10 09:40:57 UTC 
Created attachment 181637 [details]
Patch

https://blog.s9y.org/archives/274-Serendipity-2.1.1-released.html
https://blog.s9y.org/archives/273-Serendipity-2.1.0-released.html

Make test is fine.

Poudriere build fine for:

10.3 amd + i386
11.0 amd + i386
12-current amd + i386 (r314826)

portlint is also fine.

Cheers
jochen
Comment 1 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-04-10 11:09:16 UTC 
Aloha Jochen,

that patch itself looks fine. But after looking at the Makefile i would question if we really still needing the RUN_DEPENDS. Would you like to try find out?
If not its fine, just want to give you the opportunity.

Greetings,
Torsten
Comment 2 Jochen Neumeister freebsd_committer freebsd_triage 2017-04-10 15:58:54 UTC 
(In reply to Torsten Zuehlsdorff from comment #1)

Hi Torsten,

i will ckeck it and give you a feedback about the RUN_DEPENDS.

jochen
Comment 3 Jochen Neumeister freebsd_committer freebsd_triage 2017-04-12 14:46:20 UTC 
Created attachment 181718 [details]
Patch

Hi Torsten,

i remove the line, and it works fine.

tested with "make test" and in poudriere, too.

Cheers
Jochen
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-05-03 15:05:09 UTC 
A commit references this bug:

Author: tz
Date: Wed May  3 15:04:37 UTC 2017
New revision: 440018
URL: https://svnweb.freebsd.org/changeset/ports/440018

Log:
  www/serendipity: Update from 2.0.5 to 2.1.1

  Changelog: https://blog.s9y.org/archives/273-Serendipity-2.1.0-released.html
  Changelog: https://blog.s9y.org/archives/274-Serendipity-2.1.1-released.html

  Also remove no longer needed dependency.

  PR:           218526
  Submitted by: Jochen Neumeister <joneum@bsdproject.de>

Changes:
  head/www/serendipity/Makefile
  head/www/serendipity/distinfo
  head/www/serendipity/pkg-plist
Comment 5 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-05-03 15:07:39 UTC 
(In reply to Jochen Neumeister from comment #3)

> i remove the line, and it works fine.

For the record (and the future): this is not enough for PHP ports. PHP ports will always build fine, when dropping a PHP dependence. Since its an interpreter and executed after the installation of the port, there is no possibility to find the error.

Also make test just does nothing in the case and isn't a satisfying test for it.

I analyzed the code for usage of this Pear class, but could not find any explicit or implicit entry. There is a vague change, it got broke by this removal, but i doubt it. The project seems to ship all needed libraries at its own.