Bug 218548 - audio/cmus: Broken interface after oudate to 2.8.0-rc0
Summary: audio/cmus: Broken interface after oudate to 2.8.0-rc0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias Kortkamp
URL: https://reviews.freebsd.org/D10355
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-10 17:53 UTC by Oleh Hushchenkov
Modified: 2017-04-11 14:07 UTC (History)
0 users

See Also:
tobik: maintainer-feedback+

Attachments
Screenshot cmus 2.8.0-rc0 (111.14 KB, image/png)
2017-04-10 17:53 UTC, Oleh Hushchenkov 		no flags Details
Screenshot cmus 2.7.1 (152.05 KB, image/png)
2017-04-10 17:54 UTC, Oleh Hushchenkov 		no flags Details
cmus.diff (2.25 KB, patch)
2017-04-11 02:53 UTC, Tobias Kortkamp 		tobik: maintainer-approval+
Details | Diff
cmus.diff (1.07 KB, patch)
2017-04-11 03:18 UTC, Tobias Kortkamp 		tobik: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleh Hushchenkov 2017-04-10 17:53:47 UTC 
Created attachment 181662 [details]
Screenshot cmus 2.8.0-rc0

Update to 2.8.0-rc0 broke user interface.

Cmus compiled with ncurses from ports.
Comment 1 Oleh Hushchenkov 2017-04-10 17:54:44 UTC 
Created attachment 181663 [details]
Screenshot cmus 2.7.1
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2017-04-11 02:53:52 UTC 
Created attachment 181675 [details]
cmus.diff

This is a lot trickier than I thought.  I don't know why I didn't see
it before.  What I think is happening is that cmus picks up
/usr/include/curses.h which has different definitions than
devel/ncurses which leads to the garbage we see.  But it's hard to
tell for sure.

I came up with a patch that fixes the issue on my system.  Can you
test please?
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2017-04-11 03:18:24 UTC 
Created attachment 181676 [details]
cmus.diff

Small update. The configure script patch isn't necessary.
Comment 4 Oleh Hushchenkov 2017-04-11 05:30:16 UTC 
Hi Tobias.

Thanks for your work on this. Patch fixed issue for me.

Best regards.
Comment 5 Tobias Kortkamp freebsd_committer freebsd_triage 2017-04-11 05:54:56 UTC 
(In reply to Oleg Gushchenkov from comment #4)
Thanks for testing so quickly.  I'll commit this ASAP.
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-04-11 14:05:31 UTC 
A commit references this bug:

Author: tobik
Date: Tue Apr 11 14:04:38 UTC 2017
New revision: 438262
URL: https://svnweb.freebsd.org/changeset/ports/438262

Log:
  Fix broken UI when linking with devel/ncurses

  ports r438165 fixed building cmus with devel/ncurses installed, but
  stripped NCURSES_CFLAGS too aggressivly.  The build picked up base's
  curses.h over the correct headers from devel/ncurses.

  PR:		218548
  Reported by:	Oleg Gushchenkov <gor@clogic.com.ua>
  Reviewed by:	Oleg Gushchenkov <gor@clogic.com.ua>
  Approved by:	mat (mentor)
  Differential Revision:	https://reviews.freebsd.org/D10355

Changes:
  head/audio/cmus/Makefile