Bug 218569 - www/firefox: GTK2 option no longer valid
Summary: www/firefox: GTK2 option no longer valid
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gecko (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-11 19:14 UTC by Matthew Rezny
Modified: 2017-04-11 21:42 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (gecko)


Attachments
remove GTK2 option (782 bytes, patch)
2017-04-11 19:14 UTC, Matthew Rezny
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Rezny freebsd_committer freebsd_triage 2017-04-11 19:14:19 UTC
Created attachment 181695 [details]
remove GTK2 option

It appears that Firefox 53 has dropped support for GTK2 so that option is no longer valid.


Reexecuting in the virtualenv
Adding configure options from /usr/obj/usr/ports/www/firefox/work/firefox-53.0/.mozconfig
  --enable-application=browser
  --enable-official-branding
  --prefix=/usr/local
  --enable-jemalloc=4
  --enable-system-cairo
  --with-system-libevent
  --enable-system-ffi
  --with-system-graphite2
  --with-system-harfbuzz
  --enable-system-hunspell
  --with-system-icu
  --with-intl-api
  --with-system-jpeg=/usr/local
  --with-system-nspr
  --with-system-nss
  --with-system-png=/usr/local
  --enable-system-pixman
  --enable-system-sqlite
  --with-system-libvpx
  --with-system-vorbis
  --with-system-ogg
  --enable-chrome-format=omni
  --enable-default-toolkit=cairo-gtk2
  --enable-update-channel=release
  --enable-pie
  --with-pthreads
  --enable-extensions=default
  --enable-necko-protocols=default
  --with-system-zlib
  --with-system-bz2
  --enable-optimize
  --enable-startup-notification
  --disable-gconf
  --disable-gnomeui
  --disable-libproxy
  --enable-alsa
  --disable-pulseaudio
  --enable-rust
  --disable-debug
  --disable-debug-symbols
  --enable-release
  --enable-dtrace
  --disable-gold
  --disable-profiling
  --disable-tests
  --disable-strip
  --disable-install-strip
  MOZ_JEMALLOC3=1
  MOZ_OPTIMIZE_FLAGS=-O3 -O3
  MOZ_GOOGLE_API_KEY=AIzaSyBsp9n41JLW8jCokwn7vhoaMejDFRd1mp8
  MOZ_JEMALLOC4=1
  PERL=/usr/local/bin/perl
checking for a shell... /bin/sh
checking for host system type... x86_64-unknown-freebsd11.0
checking for target system type... x86_64-unknown-freebsd11.0
checking whether cross compiling... no
checking for the target C compiler... /usr/bin/cc
checking whether the target C compiler can be used... yes
checking for llvm-config... not found
Traceback (most recent call last):
  File "/usr/obj/usr/ports/www/firefox/work/firefox-53.0/configure.py", line 124, in <module>
    sys.exit(main(sys.argv))
  File "/usr/obj/usr/ports/www/firefox/work/firefox-53.0/configure.py", line 29, in main
    sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
  File "/usr/obj/usr/ports/www/firefox/work/firefox-53.0/python/mozbuild/mozbuild/configure/__init__.py", line 344, in run
    self._value_for(option)
  File "/usr/obj/usr/ports/www/firefox/work/firefox-53.0/python/mozbuild/mozbuild/configure/__init__.py", line 412, in _value_for
    return self._value_for_option(obj)
  File "/usr/obj/usr/ports/www/firefox/work/firefox-53.0/python/mozbuild/mozbuild/util.py", line 925, in method_call
    cache[args] = self.func(instance, *args)
  File "/usr/obj/usr/ports/www/firefox/work/firefox-53.0/python/mozbuild/mozbuild/configure/__init__.py", line 456, in _value_for_option
    value, option_string = self._helper.handle(option)
  File "/usr/obj/usr/ports/www/firefox/work/firefox-53.0/python/mozbuild/mozbuild/configure/options.py", line 466, in handle
    ret = option.get_value(arg, origin)
  File "/usr/obj/usr/ports/www/firefox/work/firefox-53.0/python/mozbuild/mozbuild/configure/options.py", line 366, in get_value
    % (val, ', '.join("'%s'" % c for c in self.choices)))
mozbuild.configure.options.InvalidOptionError: 'cairo-gtk2' is not one of 'cairo-windows', 'cairo-gtk3', 'cairo-cocoa', 'cairo-uikit', 'cairo-android', 'cairo-gonk'
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-04-11 21:40:25 UTC
A commit references this bug:

Author: jbeich
Date: Tue Apr 11 21:39:47 UTC 2017
New revision: 438318
URL: https://svnweb.freebsd.org/changeset/ports/438318

Log:
  www/firefox: drop broken GTK2 option following upstream

  https://www.mail-archive.com/dev-platform@lists.mozilla.org/msg20523.html

  PR:		218569
  Reported by:	Walter Schwarzenfeld, Jakub Lach <jakub_lach@mailplus.pl>
  Submitted by:	rezny (based on)
  MFH:		2017Q2 (r436907 followup)

Changes:
  head/Mk/bsd.gecko.mk
  head/www/firefox/Makefile