Bug 218689 - [MAINTAINER] net-p2p/go-ethereum Upgrade to 1.6.2
Summary: [MAINTAINER] net-p2p/go-ethereum Upgrade to 1.6.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Thomas Zander
URL:
Keywords: easy, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2017-04-16 16:51 UTC by Enrique Fynn
Modified: 2017-06-03 07:35 UTC (History)
2 users (show)

See Also:
me: maintainer-feedback+

Attachments
1.6.0.diff (837 bytes, patch)
2017-04-16 16:51 UTC, Enrique Fynn 		no flags Details | Diff
go-ethereum-1.6.2.diff (2.75 KB, patch)
2017-06-01 08:39 UTC, Enrique Fynn 		me: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrique Fynn 2017-04-16 16:51:13 UTC 
Created attachment 181825 [details]
1.6.0.diff
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2017-04-17 10:40:27 UTC 
A few points I noticed:

1) OPTIONS broken
It seems in this release the following binaries are built:
# ls build/bin/
abigen          evm             geth            rlpdump         wnode
bootnode        faucet          puppeth         swarm
So the DISASM and ETHTEST options are broken.

2) Why does the port need USE_GCC? It does compile fine without it.

3) Is the RUN_DEPENDS on go really needed?
Comment 2 Thomas Zander freebsd_committer freebsd_triage 2017-04-23 19:04:46 UTC 
Ping
Comment 3 Enrique Fynn 2017-04-24 09:23:20 UTC 
Sorry about the delay.

I am trying to make config options descriptions for each item without success so far.
For example:

[X] Developer Tools:
    [X] rlpdump Prints RLP structures
    [X] disasm  Disassembles EVM code
    ...

The ideal would be to when (de)selecting "Developer Tools" all the other options toggle to the "Developer Tools", but you can still choose individually.

Another way is just listing those options, one in each line, with just one option (for "Developer Tools"). The problem in this approach is that I don't know how to make an enumeration list in the options menu.

I'll be thankful if you can suggest me something.
Comment 4 Thomas Zander freebsd_committer freebsd_triage 2017-05-01 19:07:39 UTC 
(In reply to Fynn from comment #3)

Question is why do all the different developer tools have to be selected on an individual basis? I wouldn't expect the port to become so big as to cause a problem. Why not just one knob for "developer tools"? Otherwise it's hard to know in advance what you may need or not need anyway.

Dependencies between OPTIONS can be modeled using OPT_IMPLIES, see
https://www.freebsd.org/doc/en/books/porters-handbook/book.html

but it's really advisable to keep the options list flat and as simple as possible.
Comment 5 Enrique Fynn 2017-06-01 08:39:19 UTC 
Created attachment 183120 [details]
go-ethereum-1.6.2.diff
Comment 6 Enrique Fynn 2017-06-01 08:40:11 UTC 
-Added just one "developer tools" option
-Upgrade to 1.6.2
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-06-03 07:33:27 UTC 
A commit references this bug:

Author: riggs
Date: Sat Jun  3 07:32:45 UTC 2017
New revision: 442466
URL: https://svnweb.freebsd.org/changeset/ports/442466

Log:
  Update to upstream version 1.6.2, simplify

  Details:
  - Update to upstream version 1.6.2
  - Retire existing OPTIONs in favour of the new
    DEVTOOLS, which installs all developer tools

  PR:		218689
  Submitted by:	enriquefynn@gmail.com (maintainer)

Changes:
  head/net-p2p/go-ethereum/Makefile
  head/net-p2p/go-ethereum/distinfo
  head/net-p2p/go-ethereum/pkg-plist