Created attachment 181992 [details] SVN diff, modify the puppetserver bin command Here is a patch that updates the bin command for puppetserver. There was an error in the previous patch, resulting in a bad execution shell. Here we correct the patch to modify only the shell.
Hi Zach, Actually this looks wrong too. INSTALL_DIR="/opt/puppetlabs/server/apps/puppetserver" Which also fails to create a proper package, http://pkg.miwibox.org/data/12amd64-test-testing/2017-04-15_18h26m02s/logs/errors/puppet4-4.9.4.log Can you please have a look in that too? Thanks, - Martin
I'll have a look. I'm now realizing I may not have had a clean working copy before I ran svn diff. I'll retest locally and update the patch.
(In reply to Zach Leslie from comment #2) Cool thanks :).
Created attachment 182049 [details] Updated SVN diff for shell command Here is the updated patch from svn diff. The only change from the original is the revision from what I can tell. I've validated that this builds as expected and that the resulting /usr/local/bin/puppetserver command has the correct shell path of /usr/local/bin/bash. The INSTALL_DIR that you are seeing is just part of the patch. If you apply the patch, you will see that there is a case switch for FreeBSD that has the correct INSTALL_DIR, which has already been there for some time. Let me know if this looks good, or if changes need to be made. Cheers, Zach
Hi Zach, I will look tomorrow and come back to you on that, one thing ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: @dir /opt/puppetlabs/puppet/share/locale Error: Orphaned: @dir /opt/puppetlabs/puppet/share Error: Orphaned: @dir /opt/puppetlabs/puppet Error: Orphaned: @dir /opt/puppetlabs Error: Orphaned: @dir /opt ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1 we need to patch that to correct the build package :). - Martin
Thanks Martin, I'd attempted to patch that in #216807, but it looks like that got dropped from the commit. You can see the back and forth there. I've submitted a new PR for sysutils/puppet4 in #218853 to address the issue you are pointing to. This contains the original path I'd submitted in #216807 but were dropped before commit. Let me know how it goes. Thanks for looking. Zach
Is there anything I can do to help?
Howdy, Is there a chance of this getting looked at soon? There is going to be a new release soon and I'd like to move forward. If I can help, please let me know.
Created attachment 183989 [details] svn diff of sysutils/puppetserver
A commit references this bug: Author: swills Date: Sat Jul 1 19:46:45 UTC 2017 New revision: 444833 URL: https://svnweb.freebsd.org/changeset/ports/444833 Log: sysutils/puppetserver: correct patch PR: 218804 Submitted by: Zach Leslie <freebsd@zleslie.info> (maintainer) Changes: head/sysutils/puppetserver/Makefile head/sysutils/puppetserver/files/patch-ext__bin__puppetserver
Committed, thanks!