Created attachment 182252 [details] patch
- Update 4.1.1 -> 4.1.2 - Change upstream location to GitHub - Fix required versions of dependencies
Created attachment 182294 [details] patch - Update 4.1.1 -> 4.1.2 - Add GitHub to MASTER_SITES - Fix required versions of dependencies
I'll take it.
Hi Alexander. I've submitted your patch to a review, not including Github in MASTER_SITES, keeping just SourceForge. Usually is used one or another. For use Github, take a look at this section of the Ports Handbook: https://www.freebsd.org/doc/en/books/porters-handbook/book.html#makefile-master_sites-github-description If you want to move sysutils/backuppc, sysutils/backuppc-devel and sysutils/backuppc4 to Github, please, submit another patch (for the three ports together) and include me on the CC list, I will be glad to help. And thanks for your work.
(In reply to Danilo G. Baio from comment #5) Hi Danilo, Would you clarify, what is wrong with multiple sites in MASTER_SITES list? I thought it is recommended. Have I misunderstood https://www.freebsd.org/doc/en/books/porters-handbook/book.html#makefile-master_sites ? I am afraid USE_GITHUB won't work for sysutils/backuppc and sysutils/backuppc4 as we need to fetch "prebuilt" release tarball instead of source code. As far I understand, MASTER_SITES= https://github.com/backuppc/backuppc/releases/download/${PORTVERSION}/ is the only option.
(In reply to Alexander Moisseev from comment #6) Nothing wrong in having multiple sites, it's just unusual to have SF (that have multiple mirrors) and Github together... Anyway, we can change the MASTER_SITES as you proposed... For this, could you open a new PR for all backuppc's ?
(In reply to Danilo G. Baio from comment #7) Done. Bug 219653
A commit references this bug: Author: dbaio Date: Wed May 31 00:24:12 UTC 2017 New revision: 442130 URL: https://svnweb.freebsd.org/changeset/ports/442130 Log: sysutils/backuppc4: Update to 4.1.2 Changes: https://github.com/backuppc/backuppc/releases/tag/4.1.2 PR: 219020 Submitted by: Alexander Moisseev <moiseev@mezonplus.ru> (maintainer) Approved by: garga (mentor) Differential Revision: https://reviews.freebsd.org/D10978 Changes: head/sysutils/backuppc4/Makefile head/sysutils/backuppc4/distinfo
A commit references this bug: Author: dbaio Date: Wed May 31 00:29:09 UTC 2017 New revision: 50298 URL: https://svnweb.freebsd.org/changeset/doc/50298 Log: Add Alexander Moisseev to contributors for sysutils/backuppc4 He is also the maintainer of these ports: mail/roundcube-contextmenu mail/roundcube-thunderbird_labels net/rsync-bpc sysutils/backuppc sysutils/backuppc-devel sysutils/p5-BackupPC-XS www/free-sa-devel PR: 219020 Approved by: garga (mentor) Differential Revision: https://reviews.freebsd.org/D10979 Changes: head/en_US.ISO8859-1/articles/contributors/contrib.additional.xml
Committed, thanks. I am taking the other bug. Regards.