Bug 219088 - [NEW PORT] net/radcli: Simple RADIUS client library
Summary: [NEW PORT] net/radcli: Simple RADIUS client library
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Carlos J. Puga Medina
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-05 16:46 UTC by Jov
Modified: 2017-05-18 21:21 UTC (History)
2 users (show)

See Also:


Attachments
radcli port (5.78 KB, text/plain)
2017-05-05 16:46 UTC, Jov
no flags Details
radcli shar file (4.51 KB, patch)
2017-05-06 16:09 UTC, Carlos J. Puga Medina
no flags Details | Diff
radcli shar file (4.49 KB, patch)
2017-05-11 16:47 UTC, Carlos J. Puga Medina
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jov 2017-05-05 16:46:35 UTC
Created attachment 182322 [details]
radcli port

this radius lib is recommended by the openconnect vpn server for radius AAA support.I have use it several months,just work great.
After accepted,I will submit patch for ocserv to configurable for radius support.
Comment 1 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-05-06 16:09:54 UTC
Created attachment 182338 [details]
radcli shar file
Comment 2 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-05-06 16:15:57 UTC
Add as first line in radcli/Makefile:

# Created by: Name Surname <your@email>
Comment 3 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-05-11 13:33:59 UTC
Alexey,

Can you review it? The submitter should add his name and surname, aside from that, it looks good to me.
Comment 4 Alexey Dokuchaev freebsd_committer freebsd_triage 2017-05-11 15:53:54 UTC
> COMMENT=	Simple RADIUS Client library
s/Client/client/, I don't see a reason to capitalize it.

> GH_ACCOUNT=	radcli
Not needed as it matches the PORTNAME.

> pre-configure:
>	@cd ${WRKSRC} && ./autogen.sh
Is this really needed?  I was under impression that USES+=autoreconf magically takes care of bootstrapping itself (I might be wrong here, so I'm asking, not stating).

> post-patch:
>	@${REINPLACE_CMD} -e 's|1000000000.0d|1000000000.0|g' \
>		${WRKSRC}/lib/util.c
This is weird.  How does it compile on other systems then?  Is it really a bug?  Was it submitted upstream?  In any case, if that dot in regex was supposed to mean literal dot, not a wildcard, it should be escaped.

> radcli is a library for writing RADIUS Clients. It aims to allow writing
Again, "RADIUS Clients" looks weird in English.  Unlike German, it does not capitalize nouns (unless they are proper names).
Comment 5 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-05-11 16:47:09 UTC
Created attachment 182515 [details]
radcli shar file

> COMMENT=	Simple RADIUS Client library

> s/Client/client/, I don't see a reason to capitalize it.

Done.

> GH_ACCOUNT=	radcli

> Not needed as it matches the PORTNAME.

Done.

> pre-configure:
>	@cd ${WRKSRC} && ./autogen.sh

> Is this really needed?  I was under impression that USES+=autoreconf magically > takes care of bootstrapping itself (I might be wrong here, so I'm asking, not stating).

Yes, it is necessary because autogen.sh creates the required file 'config.rpath'

> post-patch:
>	@${REINPLACE_CMD} -e 's|1000000000.0d|1000000000.0|g' \
>		${WRKSRC}/lib/util.c

> This is weird.  How does it compile on other systems then?  Is it really a bug?  > Was it submitted upstream?  In any case, if that dot in regex was supposed to mean literal dot, not a wildcard, it should be escaped.

We need to remove "d" on double because some compiler doesn't like it.

> radcli is a library for writing RADIUS Clients. It aims to allow writing

> Again, "RADIUS Clients" looks weird in English.  Unlike German, it does not capitalize nouns (unless they are proper names).

Done.
Comment 6 Jov 2017-05-12 01:28:47 UTC
> post-patch:
>	@${REINPLACE_CMD} -e 's|1000000000.0d|1000000000.0|g' \
>		${WRKSRC}/lib/util.c(In reply to Alexey Dokuchaev from comment #4)

I will report this problem to the upstream,hope this patch will be not needed in the next version.
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-05-18 21:20:16 UTC
A commit references this bug:

Author: cpm
Date: Thu May 18 21:19:32 UTC 2017
New revision: 441200
URL: https://svnweb.freebsd.org/changeset/ports/441200

Log:
  Add new port net/radcli

  radcli is a library for writing RADIUS clients. It aims to allow writing
  a RADIUS-aware application in less than 50 lines of code. It is based on the
  freeradius-client library, but legacy code has been removed; IPv6 support,
  pkg-config, TLS/DTLS, and API documentation have been added. It remains
  source compatible with radiusclient-ng and freeradius-client.

  WWW: https://radcli.github.io/radcli/

  PR:		219088
  Submitted by:	Jov <amutu@amutu.com>
  Reviewed by:	danfe

Changes:
  head/net/Makefile
  head/net/radcli/
  head/net/radcli/Makefile
  head/net/radcli/distinfo
  head/net/radcli/pkg-descr
  head/net/radcli/pkg-plist
Comment 8 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-05-18 21:21:06 UTC
Committed!

Thanks