Bug 219120 - emulators/vice: Use standard options ALSA and PULSEAUDIO
Summary: emulators/vice: Use standard options ALSA and PULSEAUDIO
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-07 14:36 UTC by Tobias Kortkamp
Modified: 2017-05-16 19:40 UTC (History)
1 user (show)

See Also:
dinoex: maintainer-feedback+

Attachments
vice.diff (1.50 KB, patch)
2017-05-07 14:37 UTC, Tobias Kortkamp 		tobik: maintainer-approval? (dinoex)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2017-05-07 14:36:38 UTC 
Currently the port uses ASOUND and PULSE to enable support for ALSA and PulseAudio.  bsd.options.desc.mk defines both the ALSA and PULSEAUDIO.
Can we use them instead?  This makes it easier to disable support for
either of them globally in /etc/make.conf.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2017-05-07 14:37:16 UTC 
Created attachment 182362 [details]
vice.diff
Comment 2 Dirk Meyer freebsd_committer freebsd_triage 2017-05-16 19:16:42 UTC 
Patch looks fine, I will merge it to vice 3.1
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-05-16 19:29:56 UTC 
A commit references this bug:

Author: dinoex
Date: Tue May 16 19:28:59 UTC 2017
New revision: 441050
URL: https://svnweb.freebsd.org/changeset/ports/441050

Log:
  - rename option ASOUND to ALSA
  - rename option PULSE to PULSEAUDIO
  PR:		219120
  Submitted by:	Tobias Kortkamp

Changes:
  head/emulators/vice/Makefile