Bug 219401 - devel/googlemock: fix shebangs
Summary: devel/googlemock: fix shebangs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlos J. Puga Medina
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2017-05-19 09:57 UTC by Carlos J. Puga Medina
Modified: 2017-05-21 11:07 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (jbeich)

Attachments
patch (687 bytes, patch)
2017-05-19 09:57 UTC, Carlos J. Puga Medina 		no flags Details | Diff
patch (686 bytes, patch)
2017-05-19 17:20 UTC, Carlos J. Puga Medina 		jbeich: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-05-19 09:57:57 UTC 
Created attachment 182738 [details]
patch

Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/gmock_doctor.py'
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/googlemock
Comment 1 Jan Beich freebsd_committer freebsd_triage 2017-05-19 15:27:53 UTC 
Comment on attachment 182738 [details]
patch

> +USES=		autoreconf libtool localbase python:-2.7 shebangfix

Does gmock_doctor.py NOT work with python3? Do you really need python for build? Maybe replace "python:-2.7" with "python:run".
Comment 2 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-05-19 17:20:38 UTC 
Created attachment 182745 [details]
patch

- Add USES= python:run instead of python:-2.7
Comment 3 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-05-19 17:24:05 UTC 
(In reply to Jan Beich (away from May 25 to June 11) from comment #1)

Indeed! It's only needed at run time.
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-05-21 11:07:10 UTC 
A commit references this bug:

Author: cpm
Date: Sun May 21 11:06:13 UTC 2017
New revision: 441375
URL: https://svnweb.freebsd.org/changeset/ports/441375

Log:
  - Fix shebangs
  - Bump PORTREVISION

  PR:		219401
  Submitted by:	cpm
  Approved by:	jbeich (maintainer)

Changes:
  head/devel/googlemock/Makefile
Comment 5 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-05-21 11:07:57 UTC 
Committed!

Thanks