Bug 219582 - devel/libunwind: missing plist entries
Summary: devel/libunwind: missing plist entries
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Danilo Egea Gondolfo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-27 00:04 UTC by John Hein
Modified: 2017-06-06 22:42 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (danilo)


Attachments
[patch] add missing entries in plist (1.14 KB, patch)
2017-05-27 00:22 UTC, John Hein
no flags Details | Diff
[patch] add DOCS option to allow pre-built man pages to be installed (1.88 KB, patch)
2017-05-30 12:21 UTC, John Hein
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2017-05-27 00:04:59 UTC
stage-qa give this for libunwind-20170113:

===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: man/man3/_U_dyn_cancel.3.gz
Error: Orphaned: man/man3/_U_dyn_register.3.gz
Error: Orphaned: man/man3/libunwind-dynamic.3.gz
Error: Orphaned: man/man3/libunwind-ia64.3.gz
Error: Orphaned: man/man3/libunwind-ptrace.3.gz
Error: Orphaned: man/man3/libunwind-setjmp.3.gz
Error: Orphaned: man/man3/libunwind.3.gz
Error: Orphaned: man/man3/unw_backtrace.3.gz
Error: Orphaned: man/man3/unw_create_addr_space.3.gz
Error: Orphaned: man/man3/unw_destroy_addr_space.3.gz
Error: Orphaned: man/man3/unw_flush_cache.3.gz
Error: Orphaned: man/man3/unw_get_accessors.3.gz
Error: Orphaned: man/man3/unw_get_fpreg.3.gz
Error: Orphaned: man/man3/unw_get_proc_info.3.gz
Error: Orphaned: man/man3/unw_get_proc_info_by_ip.3.gz
Error: Orphaned: man/man3/unw_get_proc_name.3.gz
Error: Orphaned: man/man3/unw_get_reg.3.gz
Error: Orphaned: man/man3/unw_getcontext.3.gz
Error: Orphaned: man/man3/unw_init_local.3.gz
Error: Orphaned: man/man3/unw_init_remote.3.gz
Error: Orphaned: man/man3/unw_is_fpreg.3.gz
Error: Orphaned: man/man3/unw_is_signal_frame.3.gz
Error: Orphaned: man/man3/unw_regname.3.gz
Error: Orphaned: man/man3/unw_resume.3.gz
Error: Orphaned: man/man3/unw_set_caching_policy.3.gz
Error: Orphaned: man/man3/unw_set_fpreg.3.gz
Error: Orphaned: man/man3/unw_set_reg.3.gz
Error: Orphaned: man/man3/unw_step.3.gz
Error: Orphaned: man/man3/unw_strerror.3.gz
Comment 1 John Hein 2017-05-27 00:16:55 UTC
check-orphans, not stage-qa
Comment 2 John Hein 2017-05-27 00:22:59 UTC
Created attachment 182950 [details]
[patch] add missing entries in plist
Comment 3 John Hein 2017-05-27 00:23:38 UTC
PORTREVISION should be bumped for a plist change.
Comment 4 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2017-05-28 00:18:55 UTC
Well, the man pages were generated because you have the texlive installed (latex2man). I'll just disable docs explicitly for now so we don't need to build the LaTeX packages just to have man pages.
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-05-28 00:26:26 UTC
A commit references this bug:

Author: danilo
Date: Sun May 28 00:25:27 UTC 2017
New revision: 441885
URL: https://svnweb.freebsd.org/changeset/ports/441885

Log:
  - Disable docs explicitly. Texlive is needed to build man pages and if it's detected docs are generated, causing plist errors.

  PR:		219582

Changes:
  head/devel/libunwind/Makefile
Comment 6 John Hein 2017-05-30 12:21:19 UTC
Created attachment 183068 [details]
[patch] add DOCS option to allow pre-built man pages to be installed

Yes, I see the latex2man detection now.  configure disables docs if latex2man not detected.

But you don't actually need latex2man.  The man pages are pre-built in the distribution.

Note that even if latex2man _is_ installed, the build does not regenerate the man pages since they are not out of date with respect to the .tex source.

This could be fixed upstream to allow installing the existing built documentation without having latex2man.  But this new patch (attached) pretty much does that.  It "fools" configure to allow the documentation install even if latex2man is not installed.

If you like the patch, you should probably bump PORTREVISION since it may change the plist depending on the user's selection of the DOCS option.
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-06-06 22:40:36 UTC
A commit references this bug:

Author: danilo
Date: Tue Jun  6 22:39:51 UTC 2017
New revision: 442810
URL: https://svnweb.freebsd.org/changeset/ports/442810

Log:
  - Add DOCS option. The configure script looks for latex2man tool to install docs but
    the man files are already built in the package, so we are just installing them.

  PR:		219582
  Submitted by:	 John Hein

Changes:
  head/devel/libunwind/Makefile
  head/devel/libunwind/pkg-plist
Comment 8 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2017-06-06 22:42:32 UTC
Committed, thanks!