Created attachment 183029 [details] make ninja default kde@ would like to ask for an exp-run to cmakes default generator. This makes ninja the default generator for ports having USES=cmake . Ports can opt-out with the new cmake argument 'noninja'. The patch is attached, and can also be found here: http://people.freebsd.org/~tcberner/patches/cmake_ninja.v1.diff
Here are some new failures: http://package18.nyi.freebsd.org/data/110amd64-default-PR219629/2017-05-29_18h02m01s/logs/mysql57-server-5.7.18.log http://package18.nyi.freebsd.org/data/110amd64-default-PR219629/2017-05-29_18h02m01s/logs/mysql80-server-8.0.0_4.log http://package18.nyi.freebsd.org/data/110amd64-default-PR219629/2017-05-29_18h02m01s/logs/flang-3.9.20170522_1.log http://package18.nyi.freebsd.org/data/110amd64-default-PR219629/2017-05-29_18h02m01s/logs/gemrb-0.8.4_2.log http://package18.nyi.freebsd.org/data/110amd64-default-PR219629/2017-05-29_18h02m01s/logs/kde-workspace-4.11.22_5.log
Created attachment 183075 [details] patch v2 http://people.freebsd.org/~tcberner/patches/cmake_ninja.v2.diff fix all from comment 1, but devel/flang, which does not exist for me.
(In reply to Tobias C. Berner from comment #2) I'm an idiot. Give me a minute.
Created attachment 183076 [details] patch v 2.5 + devel/flang
Here are 3 other failures: http://package18.nyi.freebsd.org/data/110amd64-default-PR219629/2017-05-30_18h12m42s/logs/gogglesmm-1.1.7_2.log http://package18.nyi.freebsd.org/data/110amd64-default-PR219629/2017-05-30_18h12m42s/logs/orthanc-1.1.0_5.log http://package18.nyi.freebsd.org/data/110amd64-default-PR219629/2017-05-30_18h12m42s/logs/kde4-style-bespin-201303202227_5.log
Created attachment 183134 [details] v3 New diff http://people.freebsd.org/~tcberner/patches/cmake_ninja.v3.diff fixes x11-themes/kde4-style-bespin - the other two I think are related to the sqlite3 update.
There seems to be new failures specific to i386 (or to non-amd64): http://package18.nyi.freebsd.org/data/110i386-default-PR219629/2017-06-03_21h07m19s/logs/errors/stp-1436_4.log http://package18.nyi.freebsd.org/data/110i386-default-PR219629/2017-06-03_21h07m19s/logs/errors/doxygen-1.8.13,2.log Around 450 ports were not tested due to those failures.
On 10.3 amd64 there is 1 new failure: graphics/osg-devel (it changes USES depending on OSVERSION) http://package18.nyi.freebsd.org/data/103amd64-default-PR219629/2017-06-04_06h09m22s/logs/errors/osg-devel-3.5.1_1.log
Created attachment 183219 [details] v4 http://people.freebsd.org/~tcberner/patches/cmake_ninja.v4.diff * marks devel/doxygen and math/stp noninja, as I could not consistently reproduce the issue. * remove the USES=gmake for 10.x from graphics/osg-devel * mark ports ignored that want to "USES=cmake gmake"
New failures on 10.3 amd64: http://package18.nyi.freebsd.org/data/103i386-default-PR219629/2017-06-05_06h33m36s/logs/errors/vavoom-1.33_14.log http://package18.nyi.freebsd.org/data/103i386-default-PR219629/2017-06-05_06h33m36s/logs/errors/tulip-4.10.0_1.log http://package18.nyi.freebsd.org/data/103i386-default-PR219629/2017-06-05_06h33m36s/logs/errors/conky-1.10.6_2.log
Created attachment 183389 [details] v5 Remove some superflous noninja's spotted by rakuco@.
(In reply to Tobias C. Berner from comment #11) Patch can also be found here: http://people.freebsd.org/~tcberner/patches/cmake_ninja.v5.diff
Created attachment 183390 [details] v6 Sorry, the previous patch had issues in the newly (not) fixed ones. Here's a new one: http://people.freebsd.org/~tcberner/patches/cmake_ninja.v6.diff
multimedia/plexhometheater is marked as broken: USES=gmake is incompatible with cmake's ninja-generator New failure logs on 11.0 amd64: http://package22.nyi.freebsd.org/data/110amd64-default-PR219629/2017-06-11_19h03m48s/logs/bullet-2.83.7_2.log http://package22.nyi.freebsd.org/data/110amd64-default-PR219629/2017-06-11_19h03m48s/logs/opencv-java-2.4.13.1_1.log http://package22.nyi.freebsd.org/data/110amd64-default-PR219629/2017-06-11_19h03m48s/logs/py27-opencv-2.4.13.1_1.log http://package22.nyi.freebsd.org/data/110amd64-default-PR219629/2017-06-11_19h03m48s/logs/libproxy-perl-0.4.12.log http://package22.nyi.freebsd.org/data/110amd64-default-PR219629/2017-06-11_19h03m48s/logs/libproxy-python-0.4.12.log
Created attachment 183434 [details] v7 New patch can be found here: http://people.freebsd.org/~tcberner/patches/cmake_ninja.v7.diff * Does not use ninja for ports that set BUILD_- or INSTALL_WRKSRC to differ from CONFIGURE_WRKSRC. * Apply complete fix to devel/bullet
New failure on 10.3 amd64: http://package22.nyi.freebsd.org/data/103amd64-default-PR219629/2017-06-13_12h38m51s/logs/errors/mariadb100-server-10.0.31.log
Created attachment 183515 [details] v8 Readd noninja to databases/mariadb100-server: http://people.freebsd.org/~tcberner/patches/cmake_ninja.v8.diff
Exp-run looks fine. There is a leftover CMAKE_NINJA=yes in graphics/rawtherapee, CMAKE_NINJA should probably be added to SANITY_DEPRECATED
(In reply to Antoine Brodin from comment #18) I appended CMAKE_NINJA to SANITY_DEPRECATED in bsd.sanity.mk in the latest revision, and removed it from rawtherapee. Thanks for the many exp-runs.
A commit references this bug: Author: tcberner Date: Sun Jun 25 21:08:06 UTC 2017 New revision: 444324 URL: https://svnweb.freebsd.org/changeset/ports/444324 Log: Make ninja opt-out in cmake.mk Using ninja instead of make (1) can lead to significant speed ups while building. Therefore switch from having the ninja generator opt-in to having it opt-out. Previously cmake-ports that wanted to use ninja could set CMAKE_NINJA=yes now, ports that do not work with ninja can set cmake:<existing args>,noninja Note, that needing this should be an exception and most often points to a broken cmake of the port. The ports using cmake were modified * removed USES=gmake, if ninja is used * removed MAKE_ARGS, if ninja is used * added the cmake-argument noninja if necessary PR: 219629 PR: 213331 Exp-run by: antoine Reviewed by: rakuco Differential Revision: https://reviews.freebsd.org/D10748 Changes: head/CHANGES head/Mk/Uses/cmake.mk head/Mk/bsd.sanity.mk head/astro/marble/Makefile head/audio/csound6/Makefile head/audio/fluidsynth/Makefile head/audio/libgme/Makefile head/cad/kicad/Makefile head/cad/opencascade/Makefile head/cad/openvsp/Makefile head/chinese/fcitx/Makefile head/chinese/ibus-chewing/Makefile head/comms/uhd/Makefile head/comms/usrp/Makefile head/databases/cppdb/Makefile head/databases/evolution-data-server/Makefile head/databases/mariadb100-server/Makefile head/databases/mariadb55-server/Makefile head/databases/mysql55-server/Makefile head/databases/mysql56-server/Makefile head/databases/mysql57-server/Makefile head/databases/mysql80-server/Makefile head/databases/mysqlwsrep56-server/Makefile head/databases/percona55-server/Makefile head/databases/percona56-server/Makefile head/databases/percona57-server/Makefile head/databases/tarantool/Makefile head/databases/xtrabackup/Makefile head/deskutils/kdeconnect/Makefile head/deskutils/kdepim4/Makefile head/deskutils/owncloudclient/Makefile head/devel/bullet/Makefile head/devel/compiler-rt/Makefile head/devel/doxygen/Makefile head/devel/flang/Makefile head/devel/flang-clang/Makefile head/devel/kapptemplate/Makefile head/devel/kdevelop-kde4/Makefile head/devel/kdevelop-php/Makefile head/devel/libzrtpcpp/Makefile head/devel/llvm-cheri/Makefile head/devel/llvm-devel/Makefile head/devel/llvm38/Makefile head/devel/llvm39/Makefile head/devel/llvm40/Makefile head/devel/mongo-c-driver/Makefile head/devel/rapidjson/Makefile head/devel/tesla/Makefile head/devel/xxhash/files/ head/devel/xxhash/files/patch-git_5ab73ee head/editors/codelite/Makefile head/editors/jucipp/Makefile head/editors/kate-plugin-pate/Makefile head/editors/neovim/Makefile head/games/hedgewars/Makefile head/games/openclonk/Makefile head/games/openmw/Makefile head/games/palomino/Makefile head/games/solarus/Makefile head/games/vavoom/Makefile head/graphics/aseprite/Makefile head/graphics/darktable/Makefile head/graphics/digikam-kde4/Makefile.common head/graphics/ilmbase/files/patch-git_8eed7012 head/graphics/inkscape/Makefile head/graphics/luxrender/Makefile head/graphics/mitsuba/Makefile head/graphics/opensubdiv/Makefile head/graphics/osg-devel/Makefile head/graphics/osgearth/Makefile head/graphics/rawtherapee/Makefile head/graphics/tulip/Makefile head/graphics/waffle/Makefile head/graphics/xcftools/Makefile head/irc/weechat/Makefile head/lang/beignet/Makefile head/lang/io/Makefile head/lang/sagittarius-scheme/Makefile head/mail/evolution/Makefile head/mail/evolution-ews/Makefile head/mail/libcmime/Makefile head/mail/libvmime/Makefile head/mail/spmfilter/Makefile head/mail/spmfilter-clamav/Makefile head/math/metis/Makefile head/math/parmetis/Makefile head/math/stp/Makefile head/multimedia/avidemux/Makefile.common head/multimedia/gstreamer-qt4/Makefile head/multimedia/plexhometheater/Makefile head/multimedia/zoneminder/Makefile head/multimedia/zoneminder-h264/Makefile head/net/ceph-devel/Makefile head/net/tigervnc/Makefile head/net-im/licq/Makefile head/net-im/ring-gnome/Makefile head/net-im/ring-libclient/Makefile head/science/paraview/Makefile head/security/kwalletmanager/Makefile head/security/libzrtpcppcore/Makefile head/sysutils/baloo/Makefile head/sysutils/conky/Makefile head/sysutils/fluent-bit/Makefile head/sysutils/kcm-polkit-kde/Makefile head/sysutils/osquery/Makefile head/textproc/clucene/Makefile head/textproc/zxing-cpp/Makefile head/www/h2o/Makefile head/www/webkit2-gtk3/Makefile head/x11/kde4-runtime/Makefile head/x11/kde4-workspace/Makefile head/x11/virtualgl/Makefile head/x11-themes/kde4-style-bespin/Makefile head/x11-themes/kde4-windeco-crystal/Makefile head/x11-wm/pawm/Makefile
Thanks again.