Created attachment 183156 [details] patch file Here is a patch for avoiding need of gettext dependency when option NLS is disabled.
Hi Enrico, no feedback about this patch ?
Hi Olivier, Sorry for the belated answer. I will have a look at the patch asap.
Hi Olivier, I had a look at the patch. I see that what the patch does is basically: * Removing ABOUT-NLS from the list of distributed files. * Purging gettext-related stuff from the Makefile. * Removing ABOUT-NLS from pkg-plist. My impressions are the following: * The first two points are actually shortcomings of the current package configuration machinery. Therefore I think we should not be modifying the package files; rather, we should update the package to conditionally use gettext only when available and/or requested. * Removing ABOUT-NLS from pkg-plist is something which we should take care of at the port side. However, according to the "FreeBSD Porter's Handbook", sec. 6.7.2 (Using GNU gettext / Optional Usage), that goal can be accomplished by simply appending the %%NLS%% prefix to the conditionally-included file path in pkg-plist. I'm actively working on the first two points and I will submit a port update shortly. Could you validate my statement about using %%NLS%%?
Created attachment 187629 [details] update to 1.11.2 and make NLS optional Update to the port that: * Downloads the release tarball attached to the specified release (as a binary file) in github. * Conditionally uses NLS.
Hi Olivier, I updated fswatch: * gettext is now used conditionally, only when NLS is used. You can see the patch I propose: * fswatch has been updated to 1.11.2 * gettext is _not_ a dependency any longer (it is only is NLS is used) * autoreconf is not used. The previous version of the port downloaded the _sources_ of fswatch at the specified tag, _not_ the release tarball. The release tarball should be used instead, as per GNU autotools workflow. What's currently happening is that autoreconf is invoked to recreate the configure script and at that stage gettext _is_ required. Using the release tarball (attached to the github release) is the documented way to build fswatch. Please, have a look at it. By the way, I wanted to simplify MASTER_SITES by using GHC but I found an issue (The :DEFAULT group used for fswatch-1.11.2.tar.gz is missing from MASTER_SITES.) and I wasn't able to promptly solve it. Cheers, -- Enrico
I forgot to mention that I tested the port with poudriere, on a 11.1-RELEASE amd64 jail with both NLS enabled and disabled, and everything works fine.
Created attachment 187633 [details] update fswatch@1.11.2 and make NLS optional
(In reply to Enrico M. Crisostomo from comment #4) Please ignore the first patch: I forgot to include a modification
A commit references this bug: Author: olivier Date: Wed Nov 1 08:40:17 UTC 2017 New revision: 453268 URL: https://svnweb.freebsd.org/changeset/ports/453268 Log: Update to 1.11.2 and conditionally uses NLS PR: 219731 Submitted by: Enrico M. Crisostomo <enrico.m.crisostomo@gmail.com> (maintainer) Changes: head/sysutils/fswatch-mon/Makefile head/sysutils/fswatch-mon/distinfo head/sysutils/fswatch-mon/pkg-plist
Thanks! I've just did very small "cosmetic" changes to the Makefile (tabulation and variables order) for being portlint compliant.