Bug 219755 - security/webfwlog: Update to 1.1.0, fix build issue, new upstream, other changes
Summary: security/webfwlog: Update to 1.1.0, fix build issue, new upstream, other changes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords:
: 224439 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-06-03 16:56 UTC by zeus
Modified: 2017-12-31 22:03 UTC (History)
2 users (show)

See Also:

Attachments
Fixes build issue, new upstream (7.65 KB, patch)
2017-06-03 16:56 UTC, zeus 		no flags Details | Diff
Revised patch to fix build issue, new upstream (8.89 KB, patch)
2017-06-07 18:02 UTC, zeus 		no flags Details | Diff
poudriere testport output (36.93 KB, text/plain)
2017-06-07 18:05 UTC, zeus 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zeus 2017-06-03 16:56:56 UTC 
Created attachment 183180 [details]
Fixes build issue, new upstream

Attached patch does the following:

    - Fix build issue (adds explicit mysql:client dependency)
    - New upstream version
    - Fully utilize USES framework
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2017-06-07 04:31:17 UTC 
If the quarterly branch version of the port is also affected, could you please separate the changes that fix bugs (like the the build issue) and the other changes (in particular version updates), so that fixes can be merged independently to the quarterly branch (without the version update), so those users can receive the fixes. 

You can add the separate build fix change (attachment) as a new issue which blocks this one (this one 'depends on' the new one).

Please also confirm that both changes (patches) pass QA (poudriere in particular)
Comment 2 zeus 2017-06-07 18:02:43 UTC 
Created attachment 183306 [details]
Revised patch to fix build issue, new upstream

No quarterly branches were affected (as of 2017Q2).

The build issue was introduced by commit 442018 on May 29 (not initiated by me) which changed the old style USE_MYSQL=server to MYSQL_USES=mysql:server. The difference is that the old style adds an implicit dependency on mysql client while the new style does not (client contains the header files), so the fix is to add an explicit client dependency.

I ran poudriere and updated the packing list for some new (orphaned) files. Also ran portlint -A and made some other, minor changes. The revised patch is attached which includes all changes. Again, no quarterly branches were affected.
Comment 3 zeus 2017-06-07 18:05:48 UTC 
Created attachment 183307 [details]
poudriere testport output
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2017-12-31 19:58:53 UTC 
*** Bug 224439 has been marked as a duplicate of this bug. ***
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2017-12-31 19:59:31 UTC 
testbuilds@work
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-12-31 20:15:49 UTC 
A commit references this bug:

Author: pi
Date: Sun Dec 31 20:14:47 UTC 2017
New revision: 457724
URL: https://svnweb.freebsd.org/changeset/ports/457724

Log:
  security/webfwlog: update 1.01 -> 1.1.0

  - unbreak, remove DEPRECATED, EXPIRATION_DATE
  - PORTREVISION needed because 1.1.0 is not larger than 1.01

  PR:		219755
  Submitted by:	zeus@ix.netcom.com (maintainer)
  Changes:	https://sourceforge.net/p/webfwlog/code/HEAD/tree/webfwlog/trunk/ChangeLog
  Relnotes:	https://sourceforge.net/p/webfwlog/code/HEAD/tree/webfwlog/trunk/ReleaseNotes

Changes:
  head/security/webfwlog/Makefile
  head/security/webfwlog/distinfo
  head/security/webfwlog/files/pkg-message.in
  head/security/webfwlog/pkg-plist
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2017-12-31 20:16:43 UTC 
Committed, thanks -- we're sorry for the delay in processing. Thanks for Walter to give the heads-up!
Comment 8 Walter Schwarzenfeld 2017-12-31 22:03:24 UTC 
Thanks for work Kurt!