Created attachment 183756 [details] Patch to fix install location of zsh completion file and enable by default net-mgmt/lldpd: Fix install location for zsh completion file - Also enable ZSH option by default to install completion file
Awaiting maintainer approval
The default directory in zsh for completion files is DATADIR/zsh/site-functions, as described in the zsh INSTALL instructions: https://sourceforge.net/p/zsh/code/ci/master/tree/INSTALL
Reported upstream also: https://github.com/vincentbernat/lldpd/issues/232
Hi Ben I'll give it a closer look, but from the first sight, that looks pretty right. Let me check back and try to give my (likely) thumbs up within a couple of days. I'm also working on bumping the port version but am hitting an issue with SNMP which I'm trying to resolve with upstream first, but didn't yet find proper time with the last couple of weeks. (https://github.com/vincentbernat/lldpd/issues/231) Thanks for reporting and offering a patch. -- Mathieu
Hi Mathieu, Any feedback? Note that the upstream issue I linked above has been fixed with a commit that performs the same change as this patch. If you are happy, I will go ahead and commit this patch? Regards, Ben
Hi Ben Sorry for the long timeout. I only now got some time to check back. Please go ahead and commit this patch. I'll try to nail down on the SNMP build options issue (with later 0.9.5+ versions) that I haven't had the chance to look further. Until then this patch is more than welcome, thanks for pushing this upstream too. Best regards, Mathieu
A commit references this bug: Author: woodsb02 Date: Fri Aug 11 10:15:12 UTC 2017 New revision: 447750 URL: https://svnweb.freebsd.org/changeset/ports/447750 Log: net-mgmt/lldpd: Fix install location for zsh completion file - Also enable ZSH option by default to install completion file PR: 220244 Approved by: Mathieu Simon <freebsd@simweb.ch> (maintainer) MFH: 2017Q3 Changes: head/net-mgmt/lldpd/Makefile head/net-mgmt/lldpd/pkg-plist
A commit references this bug: Author: woodsb02 Date: Fri Aug 11 10:17:26 UTC 2017 New revision: 447751 URL: https://svnweb.freebsd.org/changeset/ports/447751 Log: MFH: r447750 net-mgmt/lldpd: Fix install location for zsh completion file - Also enable ZSH option by default to install completion file PR: 220244 Approved by: Mathieu Simon <freebsd@simweb.ch> (maintainer) Approved by: ports-secteam blanket Changes: _U branches/2017Q3/ branches/2017Q3/net-mgmt/lldpd/Makefile branches/2017Q3/net-mgmt/lldpd/pkg-plist
Committed - thanks!